Closed Bug 1503698 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 13822 - [css-properties-values-api] Invalidate paint worklet on registration.

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 13822 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13822
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:
>  [css-properties-values-api] Invalidate paint worklet on registration.
>  
>  Due to how initial values of registered custom properties used to be
>  handled, the style diff function for custom paint could not discover that
>  the computed value for some property changed due to a new property
>  registration.
>  
>  This meant that, if you used the property '--x' in your paint worklet
>  (without applying '--x' on any element in the document), and _then_
>  registered the property '--x' (giving it an initial value), the worklet
>  would not repaint even though the computed value of --x changed from
>  "nothing" to the registered initial value.
>  
>  Now that initial values are returned from ::GetRegisteredVariable, simply
>  compare those values when diffing for custom paint invalidation.
>  
>  Note that the second test in this CL is already passing before this CL,
>  but I'm including it anyway since that case is also mentioned in the bug.
>  
>  R=ikilpatrick@chromium.org
>  
>  Bug: 657706
>  Change-Id: I2b7707d48d73693a70b100fe1121bd7f977b4db1
>  Reviewed-on: https://chromium-review.googlesource.com/1309788
>  WPT-Export-Revision: bf0acca3de8a89da5b4867b6e047b4ee1c9683a5
Ran 152 tests and 1 subtests
OK     : 1
PASS   : 1
FAIL   : 149
TIMEOUT: 2

New tests that have failures or other problems:
/css/css-paint-api/registered-property-invalidation-001.https.html: TIMEOUT
/css/css-paint-api/registered-property-invalidation-002.https.html: TIMEOUT
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/641c8c0ab44a
[wpt PR 13822] - [css-properties-values-api] Invalidate paint worklet on registration., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffa3c9f96f8e
[wpt PR 13822] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/641c8c0ab44a
https://hg.mozilla.org/mozilla-central/rev/ffa3c9f96f8e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.