1503708 - Parse empty <string> nodes in strings.xml as empty strings

Status: RESOLVED FIXED

(Localization Infrastructure and Tools :: compare-locales, defect)

Description

[Matjaz Horvat [:mathjazz]]

Empty <string> nodes in strings.xml files are parsed as Entities with the entire node markup as their value. Instead, the value should be an empty string.

Steps to reproduce:

Run this script:
> from compare_locales import parser
> p = parser.getParser("strings.xml")
> 
> p.readUnicode("""<?xml version="1.0" encoding="utf-8"?>
> <resources>
>     <string name="Empty Translation"></string>
> </resources>
> """)
> 
> list(p.parse())[0].unwrap()

Expected result:
> u''

Actual result:
> u'<string name="Empty Translation"/>'

Comment 1

[Axel Hecht [:Pike]]

Attachment: Bug 1503708, empty <string/> in Android should set value to '', r=mathjazz

Comment 2

[Axel Hecht [:Pike]]

This landed as https://hg.mozilla.org/l10n/compare-locales/rev/3ac8b87205be.

Comment 3

[Axel Hecht [:Pike]]

https://hg.mozilla.org/l10n/compare-locales/rev/55e26cac05814f64ba4fc7659c1eda1c1d7849a3 landed as follow-up, I still had a check that forbid empty strings in checks.