1503739 - Unable to restart Firefox by swipe closing it when the location services notification is shown

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Kevin Brosnan [Ex-Mozilla]]

* enable the location services preference in the settings
* encounter something like Bug 1494748 which restarting Firefox is required to fix the problem

Expected: swipe closing Firefox quits the location services or maybe interacting with the notification allows Firefox to fully close (stop scanning button?)

Actual: need to go into the Android app settings to kill Firefox or use a third party task killer

Comment 1

[Chris Peterson [:cpeterson]]

Is this a recent regression in 65 Nightly? Bug 1494748 looks like it also affects 62 and 63.

Kevin said in Slack that this bug also affects Focus+GV.

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

I expect this is fallout from background services require a foreground notification which was a requirement for the API 26 work. Bug 1384866 or one of the others from bug 1450450.

Comment 3

[Jan Henning [:JanH]]

Setting FLAG_STOP_WITH_TASK on the Stumbler service might do the trick. It does mean that the service will be stopped every time a task is removed from Recents, even if there are other tasks for the same app and Android never planned to kill the process (e.g. separate tasks for the normal browser UI and a custom tab), but I don't think there's an alternative solution to find out when the *last* task from our application has been removed, so we could stop the service only in that case.

Also someone (not me) needs to check whether FLAG_STOP_WITH_TASK actually has the desired effect when applied to the Stumbler service. From reading through the framework sources, it should work even when applied to a foreground service, but there might be other problematic configurations, which we might hit with the Stumbler service if we're unlucky.

Comment 4

[Chris Peterson [:cpeterson]]

[Tracking Requested - why for this release]:

Requesting tracking for 64 because not being able to kill Firefox is bad. Kevin suspects (comment 2) this is a regression in 63 from bug 1384866 or bug 1450450.

Comment 5

[Chris Peterson [:cpeterson]]

Hi Dylan, do you have any updates on this restart bug? Does this bug need to block Focus 8.0 release from testing GV 64 in a rollout experiment?

Comment 6

[Dylan Roeh (:droeh) (he/him)]

(In reply to Chris Peterson [:cpeterson] from comment #5)
> Hi Dylan, do you have any updates on this restart bug? Does this bug need to
> block Focus 8.0 release from testing GV 64 in a rollout experiment?

This isn't quite a dupe, but is closely related to (and should be fixed by the patch for) bug 1494748. Bouncing the NI to Kevin for Focus blocking: I personally haven't been able to reproduce this on Focus.

Comment 7

[Chris Peterson [:cpeterson]]

In anticipation of the creation of the GECKOVIEW_64_RELBRANCH next week, I am moving this bug from status-firefox64=affected to status-geckoview64=affected.

Comment 8

[Chris Peterson [:cpeterson]]

gv64=unaffected because this issue shouldn't affect GV in Focus. Whether we want to uplift to a Fennec 64.0.x dot release, I don't know.

Comment 9

[Kevin Brosnan [Ex-Mozilla]]

I was seeing a white screen in Focus when I filed this bug. However I have not seen the problem in Focus recently. Killing focus from the trash can, notification or swiping all seem to result in a usable browser the next time I use it. I agree with gv64=unaffected

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Hi Kevin, just wanted to confirm that you're still seeing this? Especially interested in Beta 65.

Comment 11

[Kevin Brosnan [Ex-Mozilla]]

I had disabled the pref. Will flip it back and see how it behaves.

Comment 12

[Kevin Brosnan [Ex-Mozilla]]

I have run into bug 1520543 which blocks me testing this.

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Kevin, can you still reproduce this in 67 or 66? Do you think it may be fixed (at least for the issue you encountered) by bug 1494748?

Comment 14

[Kevin Brosnan [Ex-Mozilla]]

The location service notification is killed when the app is swiped closed on Firefox 67. I think Dylan landed some changes a while ago for this .