Closed Bug 1503744 Opened 11 months ago Closed 11 months ago

Crash in mozilla::HTMLEditor::SetHTMLBackgroundColorWithTransaction

Categories

(Core :: Editor, defect, critical)

64 Branch
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- unaffected
firefox64 + fixed
firefox65 + fixed

People

(Reporter: wsmwk, Assigned: masayuki)

References

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

64.0b1 is the first time this signature appears. Perhaps regression. Most crashes have no add-on installed other than Lightning

This bug was filed from the Socorro interface and is
report bp-0b8dd38e-0f26-4198-a07b-072200181031.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll mozilla::HTMLEditor::SetHTMLBackgroundColorWithTransaction editor/libeditor/HTMLEditor.cpp:3020
1 xul.dll mozilla::HTMLEditor::SetBackgroundColor editor/libeditor/HTMLEditor.cpp:4629
2 xul.dll NS_InvokeByIndex xpcom/reflect/xptcall/md/win32/xptcinvoke_asm_x86_msvc.asm:54
3 xul.dll XPCWrappedNative::CallMethod js/xpconnect/src/XPCWrappedNative.cpp:1232
4 xul.dll XPC_WN_CallMethod js/xpconnect/src/XPCWrappedNativeJSOps.cpp:1019
5 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:560
6 xul.dll static bool InternalCall js/src/vm/Interpreter.cpp:614
7 xul.dll static bool Interpret js/src/vm/Interpreter.cpp:3462
8 xul.dll js::RunScript js/src/vm/Interpreter.cpp:447
9 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:587

=============================================================
Flags: needinfo?(masayuki)
Oh, thanks. Why did I check non-tip revision...

And yes, I understand. It's just a simple mistake.
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Component: General → Editor
Keywords: regression
OS: Windows 7 → All
Product: Thunderbird → Core
Hardware: x86 → All
Version: 64 → 64 Branch
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/9990ddd5ccef
Make HTMLEditor::SetHTMLBackgroundColorWithTransaction() not refer RefPtr after moving it r=m_kato
Comment on attachment 9022093 [details]
Bug 1503744 - Make HTMLEditor::SetHTMLBackgroundColorWithTransaction() not refer RefPtr after moving it

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1484133

User impact if declined: User may meet the crash.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Just fixes idiot mistake. The if condition referred RefPtr instance whose pointer has been moved to another RefPtr.

String changes made/needed: none
Attachment #9022093 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/9990ddd5ccef
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment on attachment 9022093 [details]
Bug 1503744 - Make HTMLEditor::SetHTMLBackgroundColorWithTransaction() not refer RefPtr after moving it

editor crash fix, approved for 64.0b7
Attachment #9022093 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.