Closed Bug 1503745 Opened Last year Closed 10 months ago

a bookmark item in show-more-bookmarks dropdown of bookmarks toolbar won't disappear when deleted

Categories

(Core :: Web Painting, defect, minor)

63 Branch
defect
Not set
minor

Tracking

()

VERIFIED FIXED
mozilla67
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- verified
firefox67 --- verified

People

(Reporter: euthanasia_waltz, Assigned: bradwerth)

References

Details

(Keywords: regression)

Attachments

(3 files)

Attached image before - action
When show-more-bookmarks dropdown has one item, it won't disappear if it is deleted, unless click elsewhere.

mozregression:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=98845151aee3e3873adf0d49a7e7df0c1762c0ce&tochange=c0eacd0c16628a3cdd5eadc4ebf7807ccce3fb4d
Attached image after - ghost
Blocks: 1451098
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
I've confirmed the regression range from bug 1451098 as correct.

This is simple to reproduce:

1) Add several items on the bookmarks toolbar.
2) Adjust window size so that just the last one overflows into the ">>" overflow menu.
3) Open the overflow menu
4) Right-click the item, and select Delete

=> The menu display remains (in my case with no text).
Component: Bookmarks & History → Widget: Gtk
Flags: needinfo?(bwerth)
Product: Firefox → Core
(Note: moved to Core/Widget: Gtk as that's where the original bug that caused this is).
I'll see if I can solve this.
Assignee: nobody → bwerth
Flags: needinfo?(bwerth)
Okay, just to be clear, deleting from the bookmark menu when there are multiple bookmarks showing SHOULD leave the bookmark menu behind (with the at least one remaining bookmark still visible). It's only when we delete the last bookmark that leaving behind an empty pop-up is incorrect.
Yes, I believe that's right.

Brad, do you think you'll have time to get back to this some time soon? We were triaging some bugs tagged as regressions and also weren't sure about priority here.

Flags: needinfo?(bwerth)

Sorry about dropping this. I believe the proposed patch attachment 9038602 [details] resolves things in a safe way.

Flags: needinfo?(bwerth)
Component: Widget: Gtk → Web Painting

Thanks, Brad. The treeherder link doesn't work for me; was it green (enough) to land?

Flags: needinfo?(bwerth)

No, there were test failures that need more attention. I'll get an updated try push up there and see what's left to be done.

Flags: needinfo?(bwerth)

Treeherder auto links are behaving oddly. Here's a working link: https://treeherder.mozilla.org/#/jobs?repo=try&revision=637296ebefe9a88bba8d333bbe6af875e706d9c9

Okay, I now believe this is landable. I'll ask for review.

Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d5095f40e1c
Make widgets with empty bounds consistently hide themselves. r=karlt
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Is this something which should be nominated for Beta approval or can it ride the trains?

Flags: needinfo?(bwerth)

Comment on attachment 9038602 [details]
Bug 1503745: Make widgets with empty bounds consistently hide themselves.

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1451098
  • User impact if declined: Editable pop-up menus will remain on screen after their last element is removed.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This change should have no effect on widgets with real bounds, which is most widgets.
  • String changes made/needed:
Flags: needinfo?(bwerth)
Attachment #9038602 - Flags: approval-mozilla-beta?

Comment on attachment 9038602 [details]
Bug 1503745: Make widgets with empty bounds consistently hide themselves.

OK, let's take this for beta 12.

Attachment #9038602 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whiteboard: [qa-triaged]

Verified fixed on latest Nightly 67.0a1 (2019-02-28) (64-bit)and latest Beta 66.0b12 (64-bit)(buildID: 20190301012442) on Windows 10, Mac OS 10.14 and Ubuntu 16.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Whiteboard: [qa-triaged]
You need to log in before you can comment on or make changes to this bug.