1503750 - Add preference to allow crashing on repaint failures

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, enhancement)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

When a repaint fails while using Web Replay, we show the last painted graphics with a red "PAINT FAILURE" message scribbled in the upper left.  While nice for stability this isn't very helpful for figuring out why the failure occurred, and especially after bug 1503639 we'll want to find the causes of these and drive them to zero.  Still, for now I'm hesitant about always crashing on repaint failures.  The attached patch adds a preference, devtools.recordreplay.allowRepaintFailures, to control this behavior.

Comment 1

[Andrew McCreight [:mccr8]]

Comment on attachment 9021716 [details] [diff] [review]
patch

Review of attachment 9021716 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/recordreplay/ipc/ChildIPC.cpp
@@ +529,5 @@
> +  static bool gPainted;
> +  if (!gPainted) {
> +    gPainted = true;
> +
> +    gAllowRepaintFailures = Preferences::GetBool("devtools.recordreplay.allowRepaintFailures");

Doing the pref like this means users won't be able to update it while the browser is running, but I guess for a very experimental thing like this that is fine.

@@ +532,5 @@
> +
> +    gAllowRepaintFailures = Preferences::GetBool("devtools.recordreplay.allowRepaintFailures");
> +
> +    // Repaint failures are not allowed in the repaint stress mode.
> +    if (parent::InRepaintStressMode()) {

This feels like a slightly weird way to combine these two.

Maybe something like
gAllowRepaintFailures =
  Preferences::GetBool("devtools.recordreplay.allowRepaintFailures") &&
  !parent::InRepaintStressMode();
instead? I suppose that's an overly long expression.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/584368614d2c
Add preference to allow crashing on repaint failures, r=mccr8.

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/584368614d2c