1503818 - CSS change tracking - Green plus sign shows instead of red minus sign

Status: RESOLVED INVALID

(DevTools :: Inspector, defect)

Description

[u627467]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

I set devtools.inspector.changes to true in about:config. Then I wrote same CSS property multiple times with different values to Style panel in DevTools.


Actual results:

All changes were marked with Green pluses.


Expected results:

Only CSS property within selector with high specificity should be marked with green plus.

Comment 1

[u627467]

Attachment: changes.jpg

Comment 2

[Johann Hofmann [:johannh]]

That doesn't seem like a security issue to me.

Comment 3

[u627467]

(In reply to Johann Hofmann [:johannh] from comment #2)
> That doesn't seem like a security issue to me.

It's not. Sorry my bad..

Comment 4

[Razvan Caliman [:rcaliman]]

Sounds vaguely related to Bug 1500947 but we need a clearer set of steps to reproduce. 

Please see this for guidelines: https://developer.mozilla.org/en-US/docs/Mozilla/QA/Bug_writing_guidelines#Writing_precise_steps_to_reproduce

Repeated changes to the same property should coalesce into a single change. Adding then changing the same added property should result in only one add operation shown in the Changes panel for that property in that CSS rule.

Sounds like the "Expected results" is perhaps a misunderstanding. The Changes panel shows all CSS changes (coalesced where applicable) done while using the Inspector, not just the last ones which apply as a result of specificity.

Comment 5

[u627467]

You are right, I expected different behavior.. So all new css styles have green pluses and all removals have red minuses.. This is way better than I thought. I tested it and it works fine.

Comment 6

[Razvan Caliman [:rcaliman]]

Ok. Given the misunderstanding with regards to expected results, we can close this bug.