Closed Bug 1503855 Opened 1 year ago Closed 1 year ago

toolkit/modules/tests/xpcshell/test_CreditCard.js will permafail in January

Categories

(Toolkit :: Form Autofill, defect, P1, blocker)

defect

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- wontfix
firefox64 --- fixed
firefox65 --- fixed

People

(Reporter: MattN, Assigned: aryx)

References

()

Details

(Whiteboard: [webpayments-reserve])

Attachments

(1 file)

(Quoting :Gijs (he/him) from bug 1503751 comment #4)
> Is the line:
> 
>    testValid("0000000000000000", month - 1, year, false,
> 
> also going to break in january, either because it'll be negative or because
> it'll be 0, which will also be wrong?

Yes, it looks like it will

https://hg.mozilla.org/mozilla-central/annotate/3cff4bff1c9d/toolkit/modules/tests/xpcshell/test_CreditCard.js#l193
Flags: qe-verify-
Whiteboard: [webpayments] → [webpayments] [triage]
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/7e728a2e235f
Use December as previous month for credit card validity check if it's January r=MattN
Assignee: nobody → aryx.bugmail
Status: NEW → ASSIGNED
Priority: P2 → P1
Whiteboard: [webpayments] [triage] → [webpayments-reserve]
https://hg.mozilla.org/mozilla-central/rev/7e728a2e235f
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Flags: in-testsuite+
Whiteboard: [webpayments-reserve] → [webpayments-reserve][checkin-needed-beta]
Whiteboard: [webpayments-reserve][checkin-needed-beta] → [webpayments-reserve]
You need to log in before you can comment on or make changes to this bug.