Closed Bug 1503885 Opened 1 year ago Closed 1 year ago

vm/Opcodes.h spring cleaning

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

Details

Attachments

(4 files)

This file is full of weird whitespace and not-always-consistant annotations. Time to fix.
Assignee: nobody → tcampbell
- Add JOF_ARGC, JOF_YIELD instead of bare integer tags
- Fix some inconsistencies of JOF_ type and opcode size
- Reorganize JOF_ type list

Depends on D10566
Attachment #9021833 - Attachment description: Bug 1503885 - Fix (only) whitespace in Opcodes.h → Bug 1503885 - Fix whitespace (only) in vm/Opcodes.h
- Wrap comments to 80 cols
- Use consistent formatting for opcode comments

Depends on D10566
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30495babf103
Fix whitespace (only) in vm/Opcodes.h r=jandem
https://hg.mozilla.org/integration/autoland/rev/0011789dfdf2
Fix formatting in vm/Opcodes.h r=jandem
https://hg.mozilla.org/integration/autoland/rev/f09f16bcb4ab
Fix top-level comments in vm/Opcodes.h r=jandem
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ea9d1c113f2
Cleanup JOF_ types in Opcodes.h r=jandem
You need to log in before you can comment on or make changes to this bug.