Closed Bug 1503890 Opened 2 years ago Closed 2 years ago

Use MOZ_RELEASE_ASSERT for builtins that take int32 values

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: khyperia, Assigned: khyperia)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Originally from prereq work for https://bugzilla.mozilla.org/show_bug.cgi?id=1487022 . The actual bug there seems to hit a lot of issues, and that we should defer fixing it until later. Still, this prereq work is useful, so submitting it.
The arguments to the intrinsics here are not guaranteed to be int32s,
however, if a double enters the intrinsic, that's probably a bug in our
builtin javascript. Values should be converted to int32 before being
passed in, with `|0`.
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ed8f2494b6b5
Use MOZ_RELEASE_ASSERT for builtins that take int32 values. r=tcampbell
https://hg.mozilla.org/mozilla-central/rev/ed8f2494b6b5
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.