1503914 - [remote-dbg-next] add mochitest to test that clicking on refresh devices does not disconnect USB runtime

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Julian Descottes [:jdescottes]]

Follow up to Bug 1497917

We had this bug previously where clicking on "refresh devices" would clear the runtimeDetails of all the existing runtimes. Daisuke fixed it recently, it would be nice to have a mochitest for it.

Comment 1

[Julian Descottes [:jdescottes]]

The feature we want to test was initially implemented in Bug 1498103, but it looks like we already regressed this :)

Comment 2

[Julian Descottes [:jdescottes]]

This regressed because of Bug 1497448, and the following code:

    const invalidRuntimes =
      getState().runtimes.usbRuntimes.filter(r => !runtimes.includes(r));
    for (const invalidRuntime of invalidRuntimes) {
      await dispatch(disconnectRuntime(invalidRuntime.id));
    }

https://searchfox.org/mozilla-central/rev/7f7c353e969e61a6a85201cc8ad3c3de12ac30d8/devtools/client/aboutdebugging-new/src/actions/runtimes.js#216-217

Since the list of runtimes from the usb-runtimes module always returns new object, we should compare the ids instead of the objects. Otherwise we always disconnect all runtimes.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1503914 - Stop disconnecting all devices when clicking on Refresh Devices;r=daisuke

Depends on D11663

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1503914 - Add mochitest to check that USB runtimes are not disconnected on refresh;r=daisuke

Depends on D11798

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b97a83e789c2
Stop disconnecting all devices when clicking on Refresh Devices;r=daisuke
https://hg.mozilla.org/integration/autoland/rev/85d893b16842
Add mochitest to check that USB runtimes are not disconnected on refresh;r=daisuke

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/b97a83e789c2
https://hg.mozilla.org/mozilla-central/rev/85d893b16842