150396 - Cropped smiley icons

Status: RESOLVED WORKSFORME

(MailNews Core :: Composition, defect)

Description

[Christophe Thalet]

Smiley icons in the mail composer are cut off on their tops and bottoms
if line height does not allow for displaying them at their required height.
Expected behaviour: icon should be scaled down

Comment 1

[Mike Cowperthwaite]

*** Bug 206270 has been marked as a duplicate of this bug. ***

Comment 2

[Mike Cowperthwaite]

Confirming, based on dupe; resetting milestone, dropping severity to minor.

Comment 3

[Ninoschka Baca]

Branch build 2003-06-19: Mac 10.1.5
Branch build 2003-06-20: Linux RH 8
I see the problem when composing a message and after
sending/receiving/displaying the message.

Comment 4

[Mike Cowperthwaite]

Setting Hardware/OS to 'All' based on comment 3.

Comment 5

[José Jeria]

Attachment: Screenshot

Comment 6

[Kenneth]

Attachment: Mozillazine Icons

What about simply taking more attractive, textured icons, such as those used on
the Mozillazine forums, and using them?  They may be small enough to fit in the
'smaller' or 'smallest' font category.	I don't know what copyright issues with
the forums might be.  Other than that, the only option I can see is to create
new emoticons that would fit for all font sizes.

Comment 7

[Kenneth]

Attachment: Mozillazine Icons (2)

Sorry, that last attachment didn't seem to work :-P

Comment 8

[José Jeria]

Maybe not optimal, but i totally agree that the mozillazine smileys are better
than the existing ones (that are quite ugly).

Comment 9

[Alfred Kayser]

Bug 84950 fixed the 'cropped' smileys issue.
However they are still not so 'nice'.
Bug 84950 contains better images, but they are used (yet).

Comment 10

[Alfred Kayser]

Bug 199958 is about improving the look of the smileys itself.
So, after verification of the fix for the 'cropped' effect, this one can be closed.

Comment 11

[R.K.Aa.]

bug 84950 did seemingly not fix cropped smilies - see bug 84950 attachment 144857 [details]

Comment 12

[Alfred Kayser]

A kit to solve this issue can be found in bug 84950:
http://bugzilla.mozilla.org/attachment.cgi?id=143634&action=view

With this kit the smiley-span's are bound to a image construct, so
that we can do list-style-image, with -moz-image-region.
This solves two issues:
* prevents cropping of images
* use of a image-map for all the smileys (save a lot of resources).

Comment 13

[Stefan [:stefanh]]

(In reply to comment #12)
> A kit to solve this issue can be found in bug 84950:
> http://bugzilla.mozilla.org/attachment.cgi?id=143634&action=view
> 
> With this kit the smiley-span's are bound to a image construct, so
> that we can do list-style-image, with -moz-image-region.
> This solves two issues:
> * prevents cropping of images
> * use of a image-map for all the smileys (save a lot of resources).

Alfred, can you please make a patch of that so it can get reviewed? It would be nice to solve the issue once for all :)

Comment 14

[Wayne Mery (:wsmwk)]

I don't see this with current trunk of SM or TB.

Comment 15

[Stefan [:stefanh]]

Wayne, did you try with a smaller font-size? iirc, the height of the span with the smiley is determined by the height of the font, so this will always happen when the font's height is smaller that the height of the smiley icon...

Comment 16

[Wayne Mery (:wsmwk)]

yes, I tested using compozer's font size changer in html mode, i.e. not plain text.

But, is this problem caused instead by small OS default font?

Comment 17

[Stefan [:stefanh]]

Actually, they are still cropped (I think I was wrong re the font, it doesn't seem to matter) in SeaMonkey. With a fresh profile:

1) open mailnews
2) open msg compose
3) focus the content area, and do Insert --> Smiley (pick one you like)

--> smiley is cropped at the top

I think seamonkey uses different smiley icons (slightly larger) than thunderbird, so the problem might not exist in thunderbird.

Comment 18

[Stefan [:stefanh]]

oh, and this is on mac (Tiger atm) seamonkey trunk.

Comment 19

[Wayne Mery (:wsmwk)]

hmm, don't doubt you but there must be something more to causing this, because I tested SM (it was on XP).  And I just retested, changing SM default font sizes to teeny tiny 8.  I still dont see it.

Maybe no longer happens on window?  (this was reported initially as a windows)

Comment 20

[Stefan [:stefanh]]

I haven't looked at this for ages (2005), but from what I remember the issue only happened on mac. From some quick testing, it seem to depend on what font you use.

Comment 21

[Stefan [:stefanh]]

smileys in seamonkey are 19x19. They're background-images in a <span/>, which has a font-size of 17px (thunderbird has 18px in its smileys.css) and a margin-top of 2px. What probably happens is that depending of what font-family you use, the height of the span isn't enough, so the 19px high background-image get cropped, in my case it gets cropped at the top.

Comment 22

[[e-mail]]

These days we could probably fix this by making the span an inline block thus allowing us to set the height and width.

Comment 23

[Stefan [:stefanh]]

I don't see this anymore, it probably disappeared when we started to use :before. I'm resolving this as wfm.