1503999 - Enable e10s on the geckoview example app when running raptor

Status: RESOLVED FIXED

(Testing :: Raptor, enhancement)

Description

[Robert Wood [:rwood]]

:snorp pointed out on irc that e10s is supported in geckoview, but currently Raptor running on geckoview is running non-e10s - the 'example app gets launched with intent arguments that disable e10s'.

Comment 1

[Robert Wood [:rwood]]

Raptor is launching the GeckoView example app here:

https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/testing/raptor/raptor/raptor.py#213

Which uses MozDevice's ADBAndroid, and is defaulting e10s to False:

https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/testing/mozbase/mozdevice/mozdevice/adb_android.py#505

Which ultimately results in this command:

14:34:21     INFO -  adb launch_application: am start -W -n org.mozilla.geckoview_example/org.mozilla.geckoview_example.GeckoViewActivity -a android.intent.action.Main --ez use_multiprocess False --es args "-profile /sdcard/raptor-profile --es env0 LOG_VERBOSE=1 --es env1 R_LOG_LEVEL=6" -d about:blank
14:34:21     INFO -  adb shell_output: adb -s HT85S1A02743 wait-for-device shell am start -W -n 

We need to change raptor.py (top link) to incude e10s=True when calling launch_activity.

Comment 2

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9164974c1d376abe661a3b2a863a45625e28d9e

Comment 3

[Robert Wood [:rwood]]

Attachment: Bug 1503999 - Enable e10s on the geckoview example app when running raptor; r?bc

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f6501baf1d5
Enable e10s on the geckoview example app when running raptor; r=bc

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Robert Wood [:rwood] from comment #1)
> 
> We need to change raptor.py (top link) to incude e10s=True when calling
> launch_activity.

I think it's probably acceptable to change the default too. GeckoView itself defaults to using e10s, so it would make sense if the harness did too.

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/9f6501baf1d5

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

we got an alert, tests are faster:
== Change summary for alert #17354 (as of Fri, 02 Nov 2018 18:21:35 GMT) ==

Improvements:

 15%  raptor-unity-webgl-geckoview android-hw-g5-7-0-arm7-api-16 opt      221.67 -> 255.83
  4%  raptor-unity-webgl-geckoview android-hw-p2-8-0-arm7-api-16 opt      690.92 -> 721.67

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=17354

Comment 8

[Robert Wood [:rwood]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #5)

> I think it's probably acceptable to change the default too. GeckoView itself
> defaults to using e10s, so it would make sense if the harness did too.

Good suggestion, thanks, I filed Bug 1504734.