Update .taskcluster.yml to be more in-line with M-C
Categories
(Thunderbird :: Build Config, defect)
Tracking
(thunderbird_esr68 fixed)
Tracking | Status | |
---|---|---|
thunderbird_esr68 | --- | fixed |
People
(Reporter: rjl, Assigned: rjl)
Details
Attachments
(2 files, 3 obsolete files)
21.27 KB,
patch
|
mkmelin
:
approval-comm-esr68+
|
Details | Diff | Splinter Review |
21.34 KB,
patch
|
mkmelin
:
approval-comm-esr68+
|
Details | Diff | Splinter Review |
Task failure email should go to Thunderbird people rather than someone at Mozilla for whom Thunderbird is not necessarily a priority. At the same time it should be updated to be as in-sync with M-C as possible.
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
I submitted to try-comm-central with the updated file, and a simple build ran successfully. https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=20d7086e43545c9ba38116a4e0d360a4200ac992 Further testing needs to be done with cron tasks and actions, and feedback/reviews need to be solicited.
Updated•5 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
I suspect this will help with some of the cron task problems after moving to Firefox CI. It's hard to tell from the indenting change (was necessary for syntactical reasons) but there's some things that get added that specifically mention ci-admin and cron tasks. This file now will diff nicely against the one in M-C. This means that I kept the typo's in tact. The only differences should be things like "gecko"->"comm" and I kept the email-on-try-submit email out.
Assignee | ||
Comment 4•4 years ago
|
||
Comment on attachment 9107991 [details] [diff] [review] bug1504004_taskclusteryml.patch In various conversations, it seems that this file being so out of date might be causing some of our action scope problems. It should diff pretty nicely with the Firefox file now. I know this diff is pretty hard to read due to the indentation change.
Comment 5•4 years ago
|
||
Comment on attachment 9107991 [details] [diff] [review] bug1504004_taskclusteryml.patch Review of attachment 9107991 [details] [diff] [review]: ----------------------------------------------------------------- I reviewed this by diffing it with the m-c version. There's a few lines which would be identical but for insignificant changes (white-space, and a comma).
Assignee | ||
Comment 6•4 years ago
|
||
Essentially the same patch as before. - Fixed a couple of whitespace/comment differences - Fixed an instance of "try" that needs to be "try-comm-central" - Removed an old index route that is not needed
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 7•4 years ago
|
||
- Removed more old/unused routes that should not have been copied over as they were not present before - Do not send email on successful try-c-c pushes. Still sends email to push user on failure.
Assignee | ||
Updated•4 years ago
|
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/aac1db8eb71e
Update .taskcluster.yml to match Firefox's. r=darktrojan
Assignee | ||
Comment 10•4 years ago
|
||
They seem to be working after https://hg.mozilla.org/ci/ci-configuration/pushloghtml?changeset=04a70a9c63597f8f0ebf0812143adbe5b6f919ce
Assignee | ||
Comment 11•4 years ago
|
||
Comment on attachment 9108764 [details] [diff] [review] bug1504004_taskclusteryml.patch This is required for the uplift of bug 1608314.
Updated•4 years ago
|
Updated•4 years ago
|
Comment 12•4 years ago
|
||
Assignee | ||
Comment 13•4 years ago
|
||
This is the patch in attachment 9108764 [details] [diff] [review] reworked for comm-esr68.
The difference and the reason for broken in-tree actions is the inclusion of action parameters here rather than the new way found on comm-central and comm-beta.
Comment 14•4 years ago
|
||
But the patch already landed for 68, comment 12. So what's the story?
Assignee | ||
Comment 15•4 years ago
|
||
It had to be backed out because in-tree actions were broken, ie. no release promotion. I tracked it down to the missing parameters.
I posted a diff of what needs to go on c-esr68 with what we had last night to make it clearer what the difference is on
bug 1608314, attachment 9122774 [details] [diff] [review]
But, we also need ci-configuration changes to happen or the hooks behind the in-tree actions don't get rebuilt. That's bug 1611256.
Comment 16•4 years ago
|
||
You should mention backouts in the bug so that Bugzilla matches reality. (Only comm-central will do it for you.)
https://hg.mozilla.org/releases/comm-esr68/rev/0b0b3a9db37babf98482db1c0abf0abf43b5ca29
Comment 17•4 years ago
|
||
And set the flags, which I thought I had done when I clicked save.
Assignee | ||
Comment 18•4 years ago
|
||
Updated•4 years ago
|
Description
•