Closed Bug 1504004 Opened 6 years ago Closed 4 years ago

Update .taskcluster.yml to be more in-line with M-C

Categories

(Thunderbird :: Build Config, defect)

defect
Not set
normal

Tracking

(thunderbird_esr68 fixed)

RESOLVED FIXED
Thunderbird 73.0
Tracking Status
thunderbird_esr68 --- fixed

People

(Reporter: rjl, Assigned: rjl)

Details

Attachments

(2 files, 3 obsolete files)

Task failure email should go to Thunderbird people rather than someone at Mozilla for whom Thunderbird is not necessarily a priority.
At the same time it should be updated to be as in-sync with M-C as possible.
I submitted to try-comm-central with the updated file, and a simple build ran successfully.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=20d7086e43545c9ba38116a4e0d360a4200ac992

Further testing needs to be done with cron tasks and actions, and feedback/reviews need to be solicited.
Status: NEW → ASSIGNED
Summary: Update task failure email recipients in comm/.taskcluster.yml → Update .taskcluster.yml to be more in-line with M-C
Target Milestone: Thunderbird 65.0 → Thunderbird 66.0
Attachment #9033092 - Attachment is obsolete: true
Attached patch bug1504004_taskclusteryml.patch (obsolete) — Splinter Review
I suspect this will help with some of the cron task problems after moving to
Firefox CI.

It's hard to tell from the indenting change (was necessary for syntactical
reasons) but there's some things that get added that specifically mention
ci-admin and cron tasks.

This file now will diff nicely against the one in M-C. This means that I kept
the typo's in tact. The only differences should be things like "gecko"->"comm"
and I kept the email-on-try-submit email out.
Comment on attachment 9107991 [details] [diff] [review]
bug1504004_taskclusteryml.patch

In various conversations, it seems that this file being so out of date might be causing some of our action scope problems.

It should diff pretty nicely with the Firefox file now. I know this diff is pretty hard to read due to the indentation change.
Attachment #9107991 - Flags: review?(geoff)
Comment on attachment 9107991 [details] [diff] [review]
bug1504004_taskclusteryml.patch

Review of attachment 9107991 [details] [diff] [review]:
-----------------------------------------------------------------

I reviewed this by diffing it with the m-c version. There's a few lines which would be identical but for insignificant changes (white-space, and a comma).
Attachment #9107991 - Flags: review?(geoff) → review+
Attached patch bug1504004_taskclusteryml.patch (obsolete) — Splinter Review
Essentially the same patch as before.

- Fixed a couple of whitespace/comment differences
- Fixed an instance of "try" that needs to be "try-comm-central"
- Removed an old index route that is not needed
Attachment #9107991 - Attachment is obsolete: true
- Removed more old/unused routes that should not have been copied over as
  they were not present before
- Do not send email on successful try-c-c pushes. Still sends email to push
  user on failure.
Attachment #9108741 - Attachment is obsolete: true

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/aac1db8eb71e
Update .taskcluster.yml to match Firefox's. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Just a reminder that the hooks are busted.

Flags: needinfo?(rob)
Comment on attachment 9108764 [details] [diff] [review]
bug1504004_taskclusteryml.patch

This is required for the uplift of bug 1608314.
Attachment #9108764 - Flags: approval-comm-esr68?
Target Milestone: Thunderbird 66.0 → Thunderbird 73.0
Attachment #9108764 - Flags: approval-comm-esr68? → approval-comm-esr68+

This is the patch in attachment 9108764 [details] [diff] [review] reworked for comm-esr68.

The difference and the reason for broken in-tree actions is the inclusion of action parameters here rather than the new way found on comm-central and comm-beta.

Attachment #9122771 - Flags: approval-comm-esr68?

But the patch already landed for 68, comment 12. So what's the story?

It had to be backed out because in-tree actions were broken, ie. no release promotion. I tracked it down to the missing parameters.
I posted a diff of what needs to go on c-esr68 with what we had last night to make it clearer what the difference is on
bug 1608314, attachment 9122774 [details] [diff] [review]

But, we also need ci-configuration changes to happen or the hooks behind the in-tree actions don't get rebuilt. That's bug 1611256.

You should mention backouts in the bug so that Bugzilla matches reality. (Only comm-central will do it for you.)
https://hg.mozilla.org/releases/comm-esr68/rev/0b0b3a9db37babf98482db1c0abf0abf43b5ca29

And set the flags, which I thought I had done when I clicked save.

Attachment #9122771 - Flags: approval-comm-esr68? → approval-comm-esr68+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: