1504017 - Fix and re-enable webp's NEON on aarch64-windows

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, enhancement, P3)

Description

[(Away)]

Disabled in bug 1504016 for build bustage

Comment 1

[(Away)]

Attachment: Bug 1504017: Enable building libwebp's NEON code in clang-cl builds.

clang-cl can compile these files just fine. In fact, clang-cl builds _need_ to compile these files to avoid linker bustage, because code elsewhere detects `ifdef __aarch64__` and makes calls to the NEON functions.

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 9031747 [details] [diff] [review]
Bug 1504017: Enable building libwebp's NEON code in clang-cl builds.

Review of attachment 9031747 [details] [diff] [review]:
-----------------------------------------------------------------

Free wins when we change to clang-cl, yay.

::: media/libwebp/src/dsp/moz.build
@@ +35,5 @@
>      DEFINES['WEBP_HAVE_NEON'] = 1;
>      for f in SOURCES:
>        if f.endswith('neon.c'):
>          SOURCES[f].flags += CONFIG['NEON_FLAGS']
> +elif CONFIG['CPU_ARCH'] == 'aarch64' and CONFIG['CC_TYPE'] != 'MSVC':

CC_TYPE's value everywhere else is lowercase, so I think this needs to be lowercase, too?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9847f87d870b
Enable building libwebp's NEON code in clang-cl builds. r=froydnj

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/9847f87d870b