1504068 - Mach build of Firefox 65 on Ubuntu 16.04 fails to build after update, log shows errors from files in mozilla-central/config/ and gfx/skia/skia/src/core/

Status: RESOLVED DUPLICATE of bug 1503884

(Core :: Graphics, defect)

Description

[Adam Holm]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36

Steps to reproduce:

Ran 'hg pull' followed by 'hg up central' to update my local repo to the current tip of mozilla-central (changeset: 182a1b088330), then ran './mach -l machbuild.out build' in '~/src/mozilla-central/'. This was all done on Ubuntu 16.04



Actual results:

The build of Firefox fails, and the log file reports errors during the build, this is the relevant portion of the log file:

[1541108506.847905, "build_output", {"line": "\u001b[1m/home/ash/src/mozilla-central/gfx/skia/skia/src/core/SkScan_AntiPath.cpp:636:9: \u001b[0m\u001b[0;1;31merror: \u001b[0m\u001b[1muse of undeclared identifier 'isnan'\u001b[0m"}]
[1541108506.848419, "build_output", {"line": "    if (sk_float_isnan(complexity)) {  // it may be possible to have 0.0 / 0.0; inf is fine for us."}]
[1541108506.848782, "build_output", {"line": "\u001b[0;1;32m        ^"}]
[1541108506.849129, "build_output", {"line": "\u001b[0m\u001b[1m/home/ash/src/mozilla-central/gfx/skia/skia/include/core/../private/SkFloatingPoint.h:81:37: \u001b[0m\u001b[0;1;30mnote: \u001b[0mexpanded from macro 'sk_float_isnan'\u001b[0m"}]
[1541108506.849487, "build_output", {"line": "    #define sk_float_isnan(x)       isnan(x)"}]
[1541108506.849817, "build_output", {"line": "\u001b[0;1;32m                                    ^"}]
[1541108506.946055, "build_output", {"line": "\u001b[0m1 error generated."}]
[1541108506.954809, "build_output", {"line": "/home/ash/src/mozilla-central/config/rules.mk:1126: recipe for target 'SkScan_AntiPath.o' failed"}]
[1541108506.955243, "build_output", {"line": "make[4]: *** [SkScan_AntiPath.o] Error 1"}]
[1541108506.955583, "build_output", {"line": "/home/ash/src/mozilla-central/config/recurse.mk:74: recipe for target 'gfx/skia/target' failed"}]
[1541108506.955912, "build_output", {"line": "make[3]: *** [gfx/skia/target] Error 2"}]
[1541108506.95623, "build_output", {"line": "make[3]: *** Waiting for unfinished jobs...."}]
[1541108616.585102, "build_output", {"line": "/home/ash/src/mozilla-central/config/recurse.mk:32: recipe for target 'compile' failed"}]
[1541108616.585435, "build_output", {"line": "make[2]: *** [compile] Error 2"}]
[1541108616.585727, "build_output", {"line": "/home/ash/src/mozilla-central/config/rules.mk:431: recipe for target 'default' failed"}]
[1541108616.585953, "build_output", {"line": "make[1]: *** [default] Error 2"}]
[1541108616.586136, "build_output", {"line": "client.mk:125: recipe for target 'build' failed"}]
[1541108616.58632, "build_output", {"line": "make: *** [build] Error 2"}]


Expected results:

Successful build of Firefox

Comment 1

[Paul Bone [:pbone]]

Hi Adrian, Can you check that this is fixed in mozilla-central as of a few hours ago?

Comment 2

[Paul Bone [:pbone]]

Hi Adam, Can you check that this is fixed in mozilla-central as of a few hours ago?

(sorry I didn't read your name properly)

Comment 3

[Adam Holm]

(In reply to Paul Bone [:pbone] from comment #2)
> Hi Adam, Can you check that this is fixed in mozilla-central as of a few
> hours ago?

It's fixed for me, I got a successful build after updating.

> 
> (sorry I didn't read your name properly)

No worries :)