1504076 - Massive Mozmill failure 2018-11-02: ~217 Failing tests

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

Attachment: mozill-failure.txt

About 217 failing tests, click
https://treeherder.mozilla.org/#/jobs?repo=comm-central&selectedJob=209308876&revision=fa7b4b68119e8a24335b103eca102c6315d672cf
to see them all or consult the attachment.

If I'm not mistaken Windows and Mac tests still appear to work, at time of writing Windows Z2-Z4 and Mac Z2 were green, Z1 not finished.

https://taskcluster-artifacts.net/WEf5T55KRymGYiMMz7MD0g/0/public/logs/live_backing.log
says:
EXCEPTION: Timed out waiting for message display completion.

Also many:
JavaScript error: chrome://global/content/customElements.js, line 78: TypeError: child is null; can't access its "removeAttribute" property

M-C last good: 182a1b088330a2d72310ae2561004d9555
M-C first bad: 2dd516cee24f58f9b833d9db676c5752b2
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=182a1b088330a2d72310ae2561004d9555&tochange=2dd516cee24f58f9b833d9db676c5752b2

Nothing obvious.

Geoff, maybe you can fix this one while Europe sleeps.

Comment 1

[Jorg K (CEST = GMT+2)]

Windows 7 opt completely green now.

Comment 2

[Jorg K (CEST = GMT+2)]

Mac debug also green. What's going on on Linux :-( ?

Comment 3

[Jorg K (CEST = GMT+2)]

4548dcc2c7f6 Victor Porof — Bug 1499423 - Migrate the 3 treecol bindings into a Custom Element, r=bgrins ?

Comment 4

[Richard Marti (:Paenglab)]

If the treecol binding bug is the reason, Arshad is on bug 1502988 to reimplement the treecol-images.

Comment 5

[Geoff Lankow (:darktrojan)]

(In reply to Jorg K (GMT+2) from comment #0)
> Also many:
> JavaScript error: chrome://global/content/customElements.js, line 78:
> TypeError: child is null; can't access its "removeAttribute" property

Windows and Mac logs also have many of those, so I'm guessing that's not the problem.

(In reply to Jorg K (GMT+2) from comment #2)
> What's going on on Linux :-( ?

What IS going on on Linux? Lots of these failures are only happening there lately. Are the others not reporting properly?

Comment 6

[Jorg K (CEST = GMT+2)]

(In reply to Geoff Lankow (:darktrojan) from comment #5)
> What IS going on on Linux? Lots of these failures are only happening there
> lately. Are the others not reporting properly?
I don't quite understand the question.
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=53c3270b2956df2826a253723631edec04f2cd86
Was pretty green, the crash in Z1 is reported, bug 1377692, only the failures in Z2 appear new and I wanted to wait to see whether they repeat.

Comment 7

[Geoff Lankow (:darktrojan)]

The question is: are the failures only happening on Linux, or are they happening everywhere but only reported on Linux? It was more of a comment than a question anyway.

Comment 8

[Magnus Melin [:mkmelin]]

The mozmill failures were resolved with bug 1502988, but it doesn't fix the console errors:

JavaScript error: chrome://global/content/customElements.js, line 78: TypeError: child is null; can't access its "removeAttribute" property



Seems like this is coming from lightning. (No errors with --safe-mode).

Specifically the unifinder-search-results-tree-col-title, and so I think from bug 1499423. 

xxxmagnus-- this.id=unifinder-search-results-tree-col-title inheritAttribute child=null, attr=sortdirection
JavaScript error: chrome://global/content/customElements.js, line 79: TypeError: child is null; can't access its "removeAttribute" property


If I modify toolkit/content/widgets/tree.js to check the image is in the DOM, we don't get this error anymore. (I don't notice any problems either.) The this.isConnectedAndReady check alone seems insufficient.

    attributeChangedCallback() {
-      if (this.isConnectedAndReady) {
+      if (this.isConnectedAndReady && this.querySelector(".treecol-sortdirection")) {
        this._updateAttributes();
      }
    }

Brian, anything obvious to check?

Comment 9

[Jorg K (CEST = GMT+2)]

Fixed by bug 1502988.

Filed bug 1504199 for comment #8.

Magnus, bugs are cheap and recycling one makes things really confusing.