1504088 - Default Toolbar overlaps Calendar Toolbar

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Steve Valliere]

Attachment: tb-whoops.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0

Steps to reproduce:

I made the window narrower when the calendar was open on the right side.


Actual results:

When the calendar sidebar (?) is open (on the right) and the main window is sized narrower, the main tool bar "merges" with the calendar toolbar.  Image attached.  I say merges because the graphics & text appear to be rendered with transparent backgrounds, making both the calendar AND main toolbar items visible when they overlap.


Expected results:

(A) The main toolbar should have collapsed/condensed to avoid overlapping -OR-
(B) The main toolbar should have been truncated -OR-
(C) The window should not have allowed sizing below a size where both toolbars would fit.

Most likely, some intelligent combination of these things.

Comment 1

[Steve Valliere]

Attachment: version info from about thunderbird

This is just for reference to show the exact version of thunderbird, downloaded and installed Oct 28, 2018.

Comment 2

[Wayne Mery (:wsmwk)]

I'm pretty sure I've seen a bug report within the past year but my search foo is not great tonight. Perhaps somene else can find it by modifying https://mzl.la/2DhOQmr

Comment 3

[WaltS48 [:walts48]]

Not having any luck finding a previous bug report.

I also see the problem with the Mail toolbar overlapping the Today Pane using 64.0b1 on Ubuntu 18.04 just by minimizing the window.

Comment 4

[WaltS48 [:walts48]]

This only happens after customizing the toolbar.

Most noticeable with "Icons Beside Text" selected. I only had to add "Next Unread" and "Previous" with "Icons Beside Text" for the overlapping to appear in TB 60 on the Windows 10 laptop.

Looking at the reporters screenshot I'm wondering if they have the Theme & Font Size Changer extension installed. It does affect the problem. With it disabled I was able to get one more item on the toolbar before the problem occurred.

If they can live with Icons only that would be a work around.

Comment 5

[Steve Valliere]

OP here:  Under the Add-ons Manager, Extensions I have Lightning and Provider for Google Calendar.  I'm using the default theme and have never installed any others.  I have no plugins at all.  After quite a bit of hunting, I found that I did have Icons beside text set for the toolbars, but the overlap is still something that should not happen.

I have "fixed" it by removing the mail (and quick filter) tool bars, which I almost never use anyway.  I'm typically a keyboard short-cut kinda of person.  Thanks for the hints about tool bar settings -- without those I would have just continued to ignore the problem.  Now I have more screen space for my message list.

Comment 6

[Richard Marti (:Paenglab)]

I think, I know how to fix.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1504088-stop-overflow.patch

This fixes it for me. I also tried to do different things on the toolbar like changing to icon and text etc. and saw no negative effects.

Maybe this is a regression of the toolbox/bar reworks in toolkit which already began in 60 or earlier.

Comment 8

[Richard Marti (:Paenglab)]

Attachment: 1504088-stop-overflow.patch

This applies on beta and ESR. Not tested but should work like on 65.

Comment 9

[Jorg K (CEST = GMT+2)]

Comment on attachment 9022442 [details] [diff] [review]
1504088-stop-overflow.patch

Sorry, that patch doesn't apply.

Comment 10

[Richard Marti (:Paenglab)]

Comment on attachment 9022443 [details] [diff] [review]
1504088-stop-overflow.patch

This patch applies on trunk too without my changes for an other bug.

Comment 11

[Jorg K (CEST = GMT+2)]

Comment on attachment 9022443 [details] [diff] [review]
1504088-stop-overflow.patch

Thanks.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/99087a5cc937
Stop overflowing the toolbars in main window. r=jorgk

Comment 13

[Jorg K (CEST = GMT+2)]

Beta (TB 64 beta 2):
https://hg.mozilla.org/releases/comm-beta/rev/b4221616b249ce8ea43d49f43670a104ed356b1d

Comment 14

[Jorg K (CEST = GMT+2)]

TB 60.3.1/60.4 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/8e4b25a12f2c5a59270761eb7fa4cf671e9cba24

Comment 15

[WaltS48 [:walts48]]

Attachment: underlaps_todaypane.png

Looks better than the overlapping, but now goes under the Today Pane when enabled.

Worse with "Icons beside Text" selected in Customize or with more items on the toolbar.

Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Thunderbird/65.0a1

Probably no way to fix it so the Menu Button appears.

Comment 16

[Richard Marti (:Paenglab)]

This is a XUL limitation and can be only fixed with the FX implementation of the overflow popup.

Comment 17

[Jorg K (CEST = GMT+2)]

ESR 60 backout for causing bug 1506946:
https://hg.mozilla.org/releases/comm-esr60/rev/c19a3e3679974a7251cd7a0626a3ff38b98b27db

Comment 18

[Jorg K (CEST = GMT+2)]

OK, changed my mind. Richard, could you please prepare a patch including the removal of chromeclass-toolbar from aboutPreferences.xml#28

Comment 19

[Richard Marti (:Paenglab)]

Attachment: 1504088-stop-overflow-ESR.patch

This should do it.

Comment 20

[Jorg K (CEST = GMT+2)]

Comment on attachment 9025096 [details] [diff] [review]
1504088-stop-overflow-ESR.patch

OK, let's see how we go with this. CSS changes are harmless, I never believed it ;-)

Comment 21

[Jorg K (CEST = GMT+2)]

TB 60.3.2/60.4 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/35f977f9404bf89931e548d707f83ae0ed95bcfc