1504154 - Port mozrunner.grant_runtime_permissions to mozdevice.ADBAndroid

Status: RESOLVED FIXED

(Testing :: Mozbase, enhancement)

Description

[Bob Clary [:bc] (inactive)]

mozrunner.grant_runtime_permissions <https://searchfox.org/mozilla-central/source/testing/mozbase/mozrunner/mozrunner/devices/android_device.py#376> is used to allow the granting of permissions to apps without the need for installation via adb install -g. The usage of adb install -g appears to be the root cause of the fennec crashes such as Bug 1496627 comment 8.

ADBAndroid.install_app should handle this.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: ADBAndroid-grant-permissions.patch

<https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&group_state=expanded&revision=f8a6345d87fceff2e818964da12c388fa263e2e9>

This is redundant with the mozrunner.grant_runtime_permissions() but it eliminates the use of adb install -g and would allow us to eliminate any uses of mozrunner.grant_runtime_permissions() as long as we using ADBAndroid.launch_application().

Comment 2

[Bob Clary [:bc] (inactive)]

<https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&group_state=expanded&revision=f8a6345d87fceff2e818964da12c388fa263e2e9>

wlach: This might help with the reported rooting related crashes in mozregression.

We should make sure to include this with the changes in bug 1504117.

Comment 3

[Geoff Brown [:gbrown]]

Comment on attachment 9022100 [details] [diff] [review]
ADBAndroid-grant-permissions.patch

Review of attachment 9022100 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mozbase/mozdevice/mozdevice/adb_android.py
@@ +449,5 @@
>          if fail_if_running and self.process_exist(app_name, timeout=timeout):
>              raise ADBError("Only one instance of an application may be running "
>                             "at once")
>  
> +        if grant_runtime_permissions and self.version >= version_codes.M:

grant_runtime_permissions() already checks for version >= version_codes.M, so perhaps eliminate this check?

Comment 4

[Bob Clary [:bc] (inactive)]

Right. Thanks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/41cabeaa42e7
[mozdevice] Add ADBAndroid.grant_runtime_permissions() and use when launching applications, r=gbrown.

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/41cabeaa42e7

Comment 7

[Geoff Brown [:gbrown]]

This broke Android 7.0 x86 geckoview-junit (tier 3): It was already perma-fail for a couple of tests, but it began crashing on startup with this change. Adding back "-g" to install_app avoids the crash:

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=df125efc7c5822de8840982bd68182d317a3163a

Maybe we need to grant additional permissions?