Open Bug 1504178 Opened 2 years ago Updated 2 years ago

[remote-dbg-next] remove redux shared head from aboutdebugging mochitest head

Categories

(DevTools :: about:debugging, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: jdescottes, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: remote-debugging-technical-debt)

After switching from waitUntilState to waitForDispatch in Bug 1497917, we no longer need shared-redux-head.js in aboutdebugging-new tests, but we are still importing the helper.

This means we should remove: 
https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/devtools/client/aboutdebugging-new/test/browser/head.js#16-19

as well as the following line:
https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/devtools/client/aboutdebugging-new/test/browser/browser.ini#11
Some other cleanups we could do here:
- set the necessary preferences via browser.ini and remove enableNewAboutDebugging()
  see example at https://searchfox.org/mozilla-central/rev/efc0d9172cb6a5849c6c4fc0f19d7fd5a2da9643/devtools/client/inspector/markup/test/browser.ini#4
- remove the unused parameters for openAboutDebugging(). They were copied from the original openAboutDebugging() method in the original aboutdebugging test folder. `await addTab("about:debugging", { window: win });` can simply become `await addTab("about:debugging");`
Priority: -- → P3

filter on: remote-debugging-m2-reserve-cleanup

Whiteboard: remote-debugging-technical-debt
You need to log in before you can comment on or make changes to this bug.