Closed Bug 1504179 Opened 6 years ago Closed 6 years ago

Intermittent editor/libeditor/tests/test_bug1497480.html | Correct number of misspellings and words. - got +0, expected 1

Categories

(Core :: DOM: Editor, defect, P5)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox64 --- fixed
firefox65 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: edgar)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1504179 - Trigger first spell-checking by moving focus to contenteditable element;
47 bytes, text/x-phabricator-request
Details | Review 
Filed by: aciure [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=209402928&repo=autoland

https://queue.taskcluster.net/v1/task/Itvi7v3zRlG6oDFHusIYQw/runs/0/artifacts/public/logs/live_backing.log

[task 2018-11-02T11:43:56.915Z] 11:43:56     INFO - Buffered messages logged at 11:42:10
[task 2018-11-02T11:43:56.915Z] 11:43:56     INFO - AddTask.js | Entering test 
[task 2018-11-02T11:43:56.915Z] 11:43:56     INFO - Buffered messages logged at 11:42:11
[task 2018-11-02T11:43:56.915Z] 11:43:56     INFO - AddTask.js | Leaving test 
[task 2018-11-02T11:43:56.915Z] 11:43:56     INFO - AddTask.js | Entering test 
[task 2018-11-02T11:43:56.915Z] 11:43:56     INFO - Buffered messages finished
[task 2018-11-02T11:43:56.915Z] 11:43:56     INFO - TEST-UNEXPECTED-FAIL | editor/libeditor/tests/test_bug1497480.html | Correct number of misspellings and words. - got +0, expected 1
[task 2018-11-02T11:43:56.918Z] 11:43:56     INFO -     SimpleTest.is@SimpleTest/SimpleTest.js:320:5
[task 2018-11-02T11:43:56.919Z] 11:43:56     INFO -     isSpellingCheckOk@editor/libeditor/tests/spellcheck.js:6:3
[task 2018-11-02T11:43:56.920Z] 11:43:56     INFO -     @editor/libeditor/tests/test_bug1497480.html:69:10
[task 2018-11-02T11:43:56.921Z] 11:43:56     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-11-02T11:43:56.922Z] 11:43:56     INFO - TEST-UNEXPECTED-FAIL | editor/libeditor/tests/test_bug1497480.html | Spell-checking should be performed when anchor navigates away from ShadowDOM 
[task 2018-11-02T11:43:56.923Z] 11:43:56     INFO -     SimpleTest.ok@SimpleTest/SimpleTest.js:275:7
[task 2018-11-02T11:43:56.924Z] 11:43:56     INFO -     @editor/libeditor/tests/test_bug1497480.html:69:7
[task 2018-11-02T11:43:56.925Z] 11:43:56     INFO - AddTask.js | Leaving test 
[task 2018-11-02T11:43:56.927Z] 11:43:56     INFO - AddTask.js | Entering test 
[task 2018-11-02T11:43:56.928Z] 11:43:56     INFO - GECKO(1223) | [1223, Main Thread] WARNING: '!EditorUtils::IsDescendantOf(aNode, *host)', file /builds/worker/workspace/build/src/editor/libeditor/HTMLEditRules.cpp, line 7832
[task 2018-11-02T11:43:56.930Z] 11:43:56     INFO - TEST-PASS | editor/libeditor/tests/test_bug1497480.html | Correct number of misspellings and words. 
[task 2018-11-02T11:43:56.935Z] 11:43:56     INFO - TEST-PASS | editor/libeditor/tests/test_bug1497480.html | Misspelling is what we think it is. 
[task 2018-11-02T11:43:56.937Z] 11:43:56     INFO - TEST-PASS | editor/libeditor/tests/test_bug1497480.html | Misspelling is what we think it is. 
[task 2018-11-02T11:43:56.938Z] 11:43:56     INFO - TEST-PASS | editor/libeditor/tests/test_bug1497480.html | Spell-checking should be performed when pressing enter in contenteditable in ShadowDOM 
[task 2018-11-02T11:43:56.939Z] 11:43:56     INFO - AddTask.js | Leaving test 
[task 2018-11-02T11:43:56.940Z] 11:43:56     INFO - GECKO(1223) | MEMORY STAT | vsize 675MB | residentFast 317MB | heapAllocated 97MB
[task 2018-11-02T11:43:56.941Z] 11:43:56     INFO - TEST-OK | editor/libeditor/tests/test_bug1497480.html | took 6115ms
[task 2018-11-02T11:43:56.943Z] 11:43:56     INFO - GECKO(1223) | ++DOMWINDOW == 61 (0xdc324800) [pid = 1223] [serial = 136] [outer = 0xe2d472f0]
echen, could you investigate this failure since this test is landed by bug 1497480?
Flags: needinfo?(echen)
I could not reproduce locally. Add some log for debugging and try to reproduce on try server.

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1&revision=0779c9674819293ba452bfc824596fe48d15ac97&group_state=expanded
(In reply to Edgar Chen [:edgar] from comment #4)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&tier=1&revision=71d099b9d9e531246f8fdcc56b7e1257329f90ba&group_
> state=expanded

Okay, the current test has an incorrect expectation for the full spell-check, it actually happens when first-time focus moves to contenteditable element (which trigger dictionary updating), not right after document loaded. I could not reproduce this intermittent failure if we correct trigger the first-time full spell-check.
Assignee: nobody → echen
Flags: needinfo?(echen)
The current test has an incorrect expectation for the first full spell-checking,
it actually happens when first-time focus moves to contenteditable element
(which trigger dictionary updating), not right after document loaded.
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/922dd9f3b12d
Trigger first spell-checking by moving focus to contenteditable element; r=smaug
https://hg.mozilla.org/mozilla-central/rev/922dd9f3b12d
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: