1504250 - Enable Rust coverage in Mac builds

Status: RESOLVED FIXED

(Testing :: Code Coverage, enhancement)

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Part 1: Add Rust nightly toolchain for Mac cross compilation

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Part 2: Use the Rust nightly toolchain on Mac ccov builds

Comment 3

[Marco Castelluccio [:marco]]

Attachment: Part 3: Enable Rust coverage for Mac builds

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 9022206 [details] [diff] [review]
Part 1: Add Rust nightly toolchain for Mac cross compilation

Review of attachment 9022206 [details] [diff] [review]:
-----------------------------------------------------------------

::: taskcluster/ci/toolchain/linux.yml
@@ +582,5 @@
>          toolchain-alias: linux64-rust-macos
>          toolchain-artifact: public/build/rustc.tar.xz
>  
> +linux64-rust-nightly-macos:
> +    description: "rust nightly repack with macos-cross support"

It seems a little weird to have this as a separate toolchain rather than rolling it into the normal linux64-rust-nightly that we have...but I guess we do this for our "normal" rust toolchains too, and it makes the downloads somewhat smaller?

@@ +597,5 @@
> +    run:
> +        using: toolchain-script
> +        script: repack_rust.py
> +        arguments: [
> +            '--channel', 'nightly-2018-09-16',

Question about this, since I have to add nightly rust builds for aarch64 windows builds: is there something special about the 2018-09-16 nightly, or could we use a newer one?  Really bleeding-edge ones are blocked by bug 1505921, but we could in principle use newer builds here?

Comment 5

[Marco Castelluccio [:marco]]

(In reply to Nathan Froyd [:froydnj] from comment #4)
> Comment on attachment 9022206 [details] [diff] [review]
> Part 1: Add Rust nightly toolchain for Mac cross compilation
> 
> Review of attachment 9022206 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: taskcluster/ci/toolchain/linux.yml
> @@ +582,5 @@
> >          toolchain-alias: linux64-rust-macos
> >          toolchain-artifact: public/build/rustc.tar.xz
> >  
> > +linux64-rust-nightly-macos:
> > +    description: "rust nightly repack with macos-cross support"
> 
> It seems a little weird to have this as a separate toolchain rather than
> rolling it into the normal linux64-rust-nightly that we have...but I guess
> we do this for our "normal" rust toolchains too, and it makes the downloads
> somewhat smaller?

Yes, I guess so. Not sure if it's actually worth it given download speed on CI is very fast, but it's just a little code duplication so it shouldn't hurt.

> @@ +597,5 @@
> > +    run:
> > +        using: toolchain-script
> > +        script: repack_rust.py
> > +        arguments: [
> > +            '--channel', 'nightly-2018-09-16',
> 
> Question about this, since I have to add nightly rust builds for aarch64
> windows builds: is there something special about the 2018-09-16 nightly, or
> could we use a newer one?  Really bleeding-edge ones are blocked by bug
> 1505921, but we could in principle use newer builds here?

I think we should be able to use a newer one, I picked this just because it was the same as the ones for Linux and Windows.
I'll land it as is for now, and we can update all of them together whenever we want.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/86df20a4c7ce
Add Rust nightly toolchain for Mac cross compilation. r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/a248bdc28e88
Use the Rust nightly toolchain on Mac ccov builds. r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/b649cba6f659
Enable Rust coverage for Mac builds. r=froydnj

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/86df20a4c7ce
https://hg.mozilla.org/mozilla-central/rev/a248bdc28e88
https://hg.mozilla.org/mozilla-central/rev/b649cba6f659