Closed Bug 1504339 Opened 10 months ago Closed 6 months ago

Use tarfile context manager in extract_tarball

Categories

(Release Engineering :: Applications: MozharnessCore, enhancement)

enhancement
Not set

Tracking

(firefox67 fixed)

RESOLVED FIXED
Tracking Status
firefox67 --- fixed

People

(Reporter: marco, Assigned: joseph.bomber)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Hi Marco

I would like to take on this bug. However I never use mercurial before. could you guide me on how to submit a patch?
Flags: needinfo?(mcastelluccio)
You can follow the guide at https://mozilla-version-control-tools.readthedocs.io/en/latest/hgmozilla/firefoxworkflow.html (but instead of pusing to MozReview using "hg push review", you are going to push to Phabricator using https://github.com/mozilla-conduit/review/blob/master/README.md#execution).
Feel free to ping me on IRC if you hit any roadblocks!
Flags: needinfo?(mcastelluccio)
Is this something that's being worked on currently, and would it be suitable for someone not so familiar with the codebase? If so, would it be possible for me to work on it?
(In reply to tjdeadma from comment #3)
> Is this something that's being worked on currently, and would it be suitable
> for someone not so familiar with the codebase? If so, would it be possible
> for me to work on it?

This is still unassigned, and it's self-contained enough that someone not familiar with the codebase can pick it up.
You can definitely work on it if you want. The bug will be assigned once a patch is uploaded.

Is it OK if I work on this? If so I just have one question, it'd be my first contribution! What would be a good way to test the change to this function?

I have the update done locally but I'm unsure ./mach build or ./mach xpcshell-test encompasses testing this function.

Flags: needinfo?(mcastelluccio)

(In reply to joseph.bomber from comment #5)

Is it OK if I work on this? If so I just have one question, it'd be my first contribution! What would be a good way to test the change to this function?

I have the update done locally but I'm unsure ./mach build or ./mach xpcshell-test encompasses testing this function.

I believe I was able to see it working, though let me know if there is a better way to test, I have submitted my patch.

If I did anything wrong my apologies, please let me know and I'll fix it!

The patch looks good! Do you know how to land it?

Flags: needinfo?(mcastelluccio)

I tried but I don't have an account on lando, no commit access, so I don't believe I can land it myself.

Assignee: nobody → joseph.bomber
Status: NEW → ASSIGNED
Keywords: checkin-needed

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4432cc596377
Use tarfile context manager in extract_tarball. r=marco

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.