Convert xbl-marquee to UA Widget

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P3
normal
RESOLVED FIXED
6 months ago
25 days ago

People

(Reporter: timdream, Assigned: timdream)

Tracking

(Blocks 2 bugs)

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

Updated

6 months ago
Priority: -- → P3
Blocks: 1505823
(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #2)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=14ff2bb74a2383a28b69d47b92dfab02d4ff6143

There are still a few test failures:

* dom/base/test/test_bug840098.html is no longer valid I think, so I will remove it in the patch.
* layout/reftests/marquee/336736-1a.html, layout/reftests/bugs/407016-1-a.html, layout/reftests/bugs/407016-1-b.html failures means I would need to readjust the style rules I set to replace display: -moz-box.
(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #3)
> * layout/reftests/marquee/336736-1a.html,
> layout/reftests/bugs/407016-1-a.html, layout/reftests/bugs/407016-1-b.html
> failures means I would need to readjust the style rules I set to replace
> display: -moz-box.

... and I realized that I don't really need to fix this because |display: -moz-box| is always available from chrome:// stylesheets.

https://searchfox.org/mozilla-central/rev/7f7c353e969e61a6a85201cc8ad3c3de12ac30d8/servo/components/style/parser.rs#151
With the lesson learned from bug 1504418, I was meant to copy some mochitests to ensure xbl-marquee continue to work, but it turned out there wasn't any.

(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #5)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=d2a3b0879c03373c4272d08da99d36310fc5cc49

moving back to -moz-box triggers other failures, investigating.
(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #8)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=970b2b0adf6d1699de54bbe130fec52052ebc670

Patch is ready for review with all test failure fixed!

Updated

5 months ago
Blocks: 1507894

Comment 11

5 months ago
Pushed by tchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/85963f594697
Convert xbl-marquee to UA Widget r=bgrins,bzbarsky

Comment 14

5 months ago
Pushed by tchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b2248edb85bb
Convert xbl-marquee to UA Widget r=bgrins,bzbarsky

Comment 15

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b2248edb85bb
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.