1504343 - Convert xbl-marquee to UA Widget

Status: RESOLVED FIXED

(Toolkit :: XUL Widgets, task, P3)

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1504343 - Convert xbl-marquee to UA Widget

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=14ff2bb74a2383a28b69d47b92dfab02d4ff6143

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #2)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=14ff2bb74a2383a28b69d47b92dfab02d4ff6143

There are still a few test failures:

* dom/base/test/test_bug840098.html is no longer valid I think, so I will remove it in the patch.
* layout/reftests/marquee/336736-1a.html, layout/reftests/bugs/407016-1-a.html, layout/reftests/bugs/407016-1-b.html failures means I would need to readjust the style rules I set to replace display: -moz-box.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #3)
> * layout/reftests/marquee/336736-1a.html,
> layout/reftests/bugs/407016-1-a.html, layout/reftests/bugs/407016-1-b.html
> failures means I would need to readjust the style rules I set to replace
> display: -moz-box.

... and I realized that I don't really need to fix this because |display: -moz-box| is always available from chrome:// stylesheets.

https://searchfox.org/mozilla-central/rev/7f7c353e969e61a6a85201cc8ad3c3de12ac30d8/servo/components/style/parser.rs#151

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2a3b0879c03373c4272d08da99d36310fc5cc49

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

With the lesson learned from bug 1504418, I was meant to copy some mochitests to ensure xbl-marquee continue to work, but it turned out there wasn't any.

(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #5)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=d2a3b0879c03373c4272d08da99d36310fc5cc49

moving back to -moz-box triggers other failures, investigating.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ffdde62854f594c9088519356ea9089012d3bb6

The display: table there serve a purpose.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=970b2b0adf6d1699de54bbe130fec52052ebc670

I turned UA Widget off by accident.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #8)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=970b2b0adf6d1699de54bbe130fec52052ebc670

Patch is ready for review with all test failure fixed!

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

One last quick try to the final patch:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=284ecaadde6e94f77619e5694047945e94e3ced5

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85963f594697
Convert xbl-marquee to UA Widget r=bgrins,bzbarsky

Comment 12

[Andrei Ciure[:aciure]]

Backed out changeset 85963f594697 (bug 1504343) for HTMLMarqueeElement.cpp build bustages

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=212381451&revision=85963f594697920ec6503c63deb45eb41e2b5ec0

failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=212382038&searchStr=linux%2Cx64%2Cdebug%2Cbuild-linux64-base-toolchains%2Fdebug%2C%28bb%29

backout: https://hg.mozilla.org/integration/autoland/rev/efc1da42132b231dbdbfe8b06d19bfee1028dbd7

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=db78d0bf1398a2aad52c5afd976aaa97e4d5eab8

I wonder why it was not caught by the previous try runs...

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2248edb85bb
Convert xbl-marquee to UA Widget r=bgrins,bzbarsky

Comment 15

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b2248edb85bb