1504355 - Nested ShadowRoots aren't visible in Inspector if node has inline text child

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: elementfrompoint.html

While writing a testcase for something else, I noticed devtools don't always show attached ShadowRoots.

Comment 1

[Patrick Brosset <:pbro>]

Julian, do you mind looking at this one and setting a corresponding priority. Thanks!

Comment 2

[Julian Descottes [:jdescottes]]

This fails because the node passes our "inlineTextChild" test.

I think the test at https://searchfox.org/mozilla-central/rev/7f7c353e969e61a6a85201cc8ad3c3de12ac30d8/devtools/server/actors/inspector/walker.js#521 is wrong. While we can't use anonymous walkers to retrieve parents or siblings of a directShadowHostChild, we should be able to fetch children using an anonymous one.

But generally speaking, any shadowHost should _not_ be considered as an inlineTextChild.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1504355 - Do not return inlineTextChild for shadow hosts in inspector walker;r=ladybenko

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/acb7047f9492
Do not return inlineTextChild for shadow hosts in inspector walker;r=ladybenko

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/acb7047f9492