Closed Bug 1504355 Opened 3 years ago Closed 3 years ago

Nested ShadowRoots aren't visible in Inspector if node has inline text child

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox65 fixed)

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: smaug, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached file elementfrompoint.html
While writing a testcase for something else, I noticed devtools don't always show attached ShadowRoots.
Julian, do you mind looking at this one and setting a corresponding priority. Thanks!
Flags: needinfo?(jdescottes)
Flags: needinfo?(jdescottes)
Summary: Nested ShadowRoots aren't visible in Inspector → Nested ShadowRoots aren't visible in Inspector if node has inline text child
Priority: -- → P3
This fails because the node passes our "inlineTextChild" test.

I think the test at https://searchfox.org/mozilla-central/rev/7f7c353e969e61a6a85201cc8ad3c3de12ac30d8/devtools/server/actors/inspector/walker.js#521 is wrong. While we can't use anonymous walkers to retrieve parents or siblings of a directShadowHostChild, we should be able to fetch children using an anonymous one.

But generally speaking, any shadowHost should _not_ be considered as an inlineTextChild.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/acb7047f9492
Do not return inlineTextChild for shadow hosts in inspector walker;r=ladybenko
https://hg.mozilla.org/mozilla-central/rev/acb7047f9492
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.