Closed Bug 1504405 Opened Last year Closed Last year

Port bug 1503306 to TB: Properly set accentcolor and textcolor properties for Light and Dark themes

Categories

(Thunderbird :: Theme, task)

task
Not set

Tracking

(thunderbird64 fixed, thunderbird65 fixed)

RESOLVED FIXED
Thunderbird 65.0
Tracking Status
thunderbird64 --- fixed
thunderbird65 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

Bug 1503306 removed the internal --chrome-* variables and uses now the --lwt-accent-color and --lwt-text-color variables.
Port of https://hg.mozilla.org/mozilla-central/rev/e1f93e89556d
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9022361 - Flags: review?(jorgk)
Should not.
Comment on attachment 9022361 [details] [diff] [review]
1504405-accent-text-color.patch

I don't see any difference, but then I also don't know where to look :-(
Attachment #9022361 - Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/5036ddd23dc3
Port bug 1503306 to TB: Properly set accentcolor and textcolor properties for Light and Dark themes. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
The changes affects the quick filter bar background, the titlebar in drawInTitlebar mode, the tabs background and text colour and the message header text colour.
Bug 1503306 got uplifted to FF 64 beta 8. Do we need to follow?
Comment on attachment 9022361 [details] [diff] [review]
1504405-accent-text-color.patch

We can do it too. I can't check now if it applies to beta.
Attachment #9022361 - Flags: approval-comm-beta?
No rush, so far we're based on FF 64 beta 7.
I'm doing some beta uplifts now. This patch doesn't apply.
Flags: needinfo?(richard.marti)
It doesn't apply because bug 1503476 wasn't uplifted. I'll ask for it.
Flags: needinfo?(richard.marti)
Attachment #9022361 - Flags: approval-comm-beta? → approval-comm-beta+
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.