Frequent browser_datetime_datepicker.js when Gecko 65 merges to Beta on 2018-12-03

VERIFIED FIXED in Firefox 65

Status

()

defect
VERIFIED FIXED
7 months ago
6 months ago

People

(Reporter: cbrindusan, Assigned: timdream)

Tracking

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox63 unaffected, firefox64 unaffected, firefox65+ verified)

Details

Attachments

(1 attachment)

This occurred due to the fact that a patch from version increase was imported in the beta simulations, specifically from bug 1501303.
In today's beta simulations (without the above mentioned patch) this failure does not appear.

Closing as Invalid. Aryx, feel free to change that if you do not agree.
Flags: needinfo?(mconley) → needinfo?(aryx.bugmail)
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → INVALID
Flags: needinfo?(aryx.bugmail)
The changes in bug 1501303 are unrelated. The failure is back in today's simulations: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=8854e713ef63dcefc8d3f70dc7df465a61dce1e5&selectedJob=209808436

Bug 1492482 is unrelated because that landed Oct 2nd (not Nov 2nd).

Likely from bug 1496242. Tim, please investigate.
Blocks: 1496242
Status: RESOLVED → REOPENED
Flags: needinfo?(timdream)
Resolution: INVALID → ---
Summary: Perma bc in browser_datetime_datepicker.js when Gecko 65 merges to Beta on 2018-12-03 → Frequent browser_datetime_datepicker.js when Gecko 65 merges to Beta on 2018-12-03
Comment hidden (obsolete)
Part I of bug 1496242 was not implemented correctly as it accesses the
nsIDateTimeInputArea methods directly on the <datetimebox> element object.
This won't work because the XBL binding is run in a non-chrome scope.
The methods it implemented are exposed thus had to be accessed via
wrappedJSObject.

Object pass to setValueFromPicker() therefore has to clone into the content scope.

We can be sure that the methods called are implemented by the XBL binding,
because the web content should not have access to <datetimebox>, which is a NAC.

A small clean-up is included in the patch also, removing the useless 3rd arguement
to the CustomEvent constructor.
Attachment #9022712 - Attachment description: Bug 1504418 - Access to nsIDateTimeInputArea interface implemented by XBL from chrome via wrappedJSObject r=bholley → Bug 1504418 - Access to nsIDateTimeInputArea interface implemented by XBL from chrome via wrappedJSObject
(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #2)
> The changes in bug 1501303 are unrelated. The failure is back in today's
> simulations:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercanc
> el%2Crunnable&revision=8854e713ef63dcefc8d3f70dc7df465a61dce1e5&selectedJob=2
> 09808436
> 
> Bug 1492482 is unrelated because that landed Oct 2nd (not Nov 2nd).
> 
> Likely from bug 1496242. Tim, please investigate.

I assumed they were because i did not find this failing on Sunday's beta simulations. Thanks for clarifying.
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)

Comment 9

6 months ago
Pushed by tchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/97fa9c6849ff
Access to nsIDateTimeInputArea interface implemented by XBL from chrome via wrappedJSObject r=mconley
Backed out changeset 97fa9c6849ff (Bug 1504418) for ES Lint failure

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=97fa9c6849ff49a08ce0a55b568e43e9ac3cc7c7

Backout link: https://hg.mozilla.org/integration/autoland/rev/1f41ed8ce41c36d7ec40c0c14b6ac774573383d3

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=211504088&repo=autoland&lineNumber=268

[task 2018-11-13T18:52:57.486Z] creating build
[task 2018-11-13T18:52:57.486Z] creating build/temp.linux-x86_64-2.7
[task 2018-11-13T18:52:57.486Z] creating build/temp.linux-x86_64-2.7/psutil
[task 2018-11-13T18:52:57.486Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2018-11-13T18:52:57.486Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2018-11-13T18:52:57.486Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_linux.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_linux.o
[task 2018-11-13T18:52:57.486Z] creating build/lib.linux-x86_64-2.7
[task 2018-11-13T18:52:57.486Z] creating build/lib.linux-x86_64-2.7/psutil
[task 2018-11-13T18:52:57.486Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o build/temp.linux-x86_64-2.7/psutil/_psutil_linux.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so
[task 2018-11-13T18:52:57.486Z] building 'psutil._psutil_posix' extension
[task 2018-11-13T18:52:57.486Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2018-11-13T18:52:57.486Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2018-11-13T18:52:57.486Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so
[task 2018-11-13T18:52:57.486Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2018-11-13T18:52:57.486Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2018-11-13T18:52:57.486Z] 
[task 2018-11-13T18:52:57.486Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2018-11-13T18:58:02.819Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/content/tests/browser/xbl/browser_datetime_datepicker.js:44:18 | 'DateTimeTestHelper' is not defined. (no-undef)
[taskcluster 2018-11-13 18:58:03.162Z] === Task Finished ===
Flags: needinfo?(timdream)
:'(
Flags: needinfo?(timdream)

Comment 12

6 months ago
Pushed by tchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b1c244f04088
Access to nsIDateTimeInputArea interface implemented by XBL from chrome via wrappedJSObject r=mconley

Comment 13

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b1c244f04088
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.