1504495 - 4 seconds of main thread work with SQLITE doing NSS stuff, on starting the profiler, and manually restoring previous session

Status: RESOLVED DUPLICATE of bug 1435141

(Core :: Security: PSM, defect)

Description

[Mayank Bansal]

Attachment: aboutsupport.txt

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

1.Using my normal profile. "Restore previous session on startup" is disabled in preferences
2.Firefox profiler installed
3. Opened a tab to https://en.miui.com/forum-207-1.html
4. Close and restart firefox.  Since previous session is not restored, a blank tab is opened.

5. Start the profiler
6. Go to the hamburger menu, and click on "Restore Previous Session"


Actual results:

main thread jank of 4 seconds.
And i use a SSD


Expected results:

maybe not so?

https://perfht.ml/2JCLpXF

Comment 1

[Mayank Bansal]

tentative ni? from :mak, because of sqlite

Comment 2

[Mark Banner (:standard8)]

Please can you explain why you think this is places (bookmarks/history) sqlite?

I could be reading it wrong, but from what I'm seeing, there's a lot of sqlite calls descending from CERT_FindUserCertsByUsage/CERT_GetCertNicknames which makes it look more like an NSS issue to me.

Comment 3

[Mark Banner (:standard8)]

FWIW I just tried this on a fresh profile on the latest nightly and couldn't reproduce.

Comment 4

[Mayank Bansal]

(In reply to Mark Banner (:standard8) from comment #2)
> Please can you explain why you think this is places (bookmarks/history)
> sqlite?
> 
> I could be reading it wrong, but from what I'm seeing, there's a lot of
> sqlite calls descending from CERT_FindUserCertsByUsage/CERT_GetCertNicknames
> which makes it look more like an NSS issue to me.

you are right, this does appear to be a NSS related. I didn't go deeper into the profile, and assumed sqlite=places.

I will change the components accordingly.

Comment 5

[Mayank Bansal]

:keeler, is this a dupe of bug 1370516 ?

Comment 6

[Mayank Bansal]

The main-thread work might be exaggerated by enabling the profiler?

Comment 7

[Dana Keeler (she/her) [:keeler]]

This is not bug 1370516. This sounds like a combination of bug 1435141 and bug 1478148. The optimization suggested in bug 1503711 might also help.