Closed Bug 1504498 Opened Last year Closed Last year

[wpt-sync] Sync PR 13893 - Rename generateOffer to generateDataChannelOffer and remove use of legacy optionsRename generateOffer to generateDataChannelOffer and remove use of legacy options

Categories

(Core :: WebRTC, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 13893 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13893
Details from upstream follow.

Youenn Fablet <youennf@gmail.com> wrote:
>   Rename generateOffer to generateDataChannelOffer and remove use of legacy optionsRename generateOffer to generateDataChannelOffer and remove use of legacy options
>  
>
Component: web-platform-tests → WebRTC
Product: Testing → Core
Ran 49 tests and 803[linux32-opt,linux64-debug,linux64-opt], 765[linux32-debug] subtests
OK     : 35[linux32-debug], 36[linux32-opt,linux64-debug,linux64-opt]
PASS   : 440[linux32-debug], 478[linux32-opt,linux64-debug,linux64-opt]
CRASH  : 1[linux32-debug]
FAIL   : 300
TIMEOUT: 20
NOTRUN : 15

Tests that CRASH:
/webrtc/RTCRtpTransceiver.https.html: [linux32-debug]

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/webrtc/RTCDTMFSender-insertDTMF.https.html: TIMEOUT
    insertDTMF() after remove and close should reject: NOTRUN
    insertDTMF() should set toneBuffer to provided tones normalized, with old tones overridden: NOTRUN
    insertDTMF() should throw InvalidStateError if transceiver.currentDirection is inactive: TIMEOUT
/webrtc/RTCPeerConnection-createAnswer.html
    createAnswer() when connection is closed reject with InvalidStateError: FAIL
/webrtc/RTCPeerConnection-onnegotiationneeded.html: TIMEOUT
    negotiationneeded event should fire only after signaling state go back to stable: TIMEOUT
/webrtc/RTCPeerConnection-removeTrack.https.html: TIMEOUT
    Calling removeTrack with currentDirection inactive should not change direction: NOTRUN
    Calling removeTrack with currentDirection recvonly should not change direction: NOTRUN
    Calling removeTrack with currentDirection sendonly should set direction to inactive: TIMEOUT
/webrtc/RTCPeerConnection-setDescription-transceiver.html: TIMEOUT
    setLocalDescription(rollback) should only unset transceiver mids associated with current round: TIMEOUT
    setRemoteDescription(rollback) should remove newly created transceiver from transceiver list: NOTRUN
/webrtc/RTCPeerConnection-setLocalDescription-answer.html: TIMEOUT
    Calling setLocalDescription(answer) from have-local-offer state should reject with InvalidStateError: NOTRUN
    Calling setLocalDescription(answer) from stable state should reject with InvalidStateError: NOTRUN
    setLocalDescription() with answer not created by own createAnswer() should reject with InvalidModificationError: TIMEOUT
/webrtc/RTCPeerConnection-setLocalDescription.html: TIMEOUT
    Calling createOffer() and setLocalDescription() again after one round of local-offer/remote-answer should succeed: TIMEOUT
    Switching role from answerer to offerer after going back to stable state should succeed: NOTRUN
    onsignalingstatechange fires before setLocalDescription resolves: NOTRUN
/webrtc/RTCPeerConnection-setRemoteDescription-pranswer.html: TIMEOUT
    setRemoteDescription(answer) from have-remote-pranswer state should succeed: NOTRUN
    setRemoteDescription(pranswer) from have-local-offer state should succeed: TIMEOUT
    setRemoteDescription(pranswer) multiple times should succeed: NOTRUN
/webrtc/RTCRtpTransceiver-setDirection.html: TIMEOUT
    setDirection should change transceiver.direction independent of transceiver.currentDirection: TIMEOUT

Tests that are disabled for instability:
/webrtc/RTCDTMFSender-ontonechange.https.html
/webrtc/RTCPeerConnection-setRemoteDescription-answer.html
/webrtc/RTCPeerConnection-setRemoteDescription-offer.html
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/21ea2095c51e
[wpt PR 13893] -  Rename generateOffer to generateDataChannelOffer and remove use of legacy optionsRename generateOffer to generateDataChannelOffer and remove use of legacy options, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/3690da2fa8b9
[wpt PR 13893] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/21ea2095c51e
https://hg.mozilla.org/mozilla-central/rev/3690da2fa8b9
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.