1504557 - Remove the XPCOM registration for nsErrorService

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Comment 1

[(no longer active)]

Attachment: Bug 1504557 - Remove the XPCOM registration for nsErrorService

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb84a3ed7bdd
Remove the XPCOM registration for nsErrorService r=froydnj

Comment 3

[Andrei Ciure[:aciure]]

Backed out changeset cb84a3ed7bdd (bug 1504557) for nsErrorService leakcheck failures

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=209733054&revision=cb84a3ed7bddc68cf1be5a31c824fa97789fa343

failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=c0536dc391c345430a421309ab67e837a89efd5d&selectedJob=209732301&searchStr=linux%2Cdebug%2Cmochitests%2Ctest-linux32%2Fdebug-mochitest-1%2Cm%281%29

backout: https://hg.mozilla.org/integration/autoland/rev/0bebbbb44c530864a4e7ce852a91eb0fed9380b0

Comment 4

[(no longer active)]

The leak was caused because txMozillaXSLTProcessor was causing a zombie service to resurrect late at shutdown under this callstack:

#0  0x00007fcda7b8822b in nsErrorService::GetOrCreate() () at /home/ehsan/moz/src/xpcom/base/nsErrorService.cpp:25
#1  0x00007fcdac489496 in txMozillaXSLTProcessor::Shutdown() () at /home/ehsan/moz/src/dom/xslt/xslt/txMozillaXSLTProcessor.cpp:1302
#2  0x00007fcdacfe952d in nsLayoutStatics::Shutdown() () at /home/ehsan/moz/src/layout/build/nsLayoutStatics.cpp:312
#3  0x00007fcda9c27767 in nsLayoutStatics::Release() () at /home/ehsan/moz/src/obj-ff-clang-plugin.noindex/dist/include/nsLayoutStatics.h:48
#4  0x00007fcdacfe94da in Shutdown() () at /home/ehsan/moz/src/layout/build/nsLayoutModule.cpp:254
#5  0x00007fcdacfe9e4c in LayoutModuleDtor() () at /home/ehsan/moz/src/layout/build/nsLayoutModule.cpp:677
#6  0x00007fcda7c7688a in nsComponentManagerImpl::KnownModule::~KnownModule() (this=0x7fcda0522220) at /home/ehsan/moz/src/xpcom/components/nsComponentManager.h:203
#7  0x00007fcda7c7682a in nsAutoPtr<nsComponentManagerImpl::KnownModule>::~nsAutoPtr() (this=0x7fcdbc556ae8) at /home/ehsan/moz/src/obj-ff-clang-plugin.noindex/dist/include/nsAutoPtr.h:78
#8  0x00007fcda7c767f5 in nsTArrayElementTraits<nsAutoPtr<nsComponentManagerImpl::KnownModule> >::Destruct(nsAutoPtr<nsComponentManagerImpl::KnownModule>*) (aE=0x7fcdbc556ae8)
    at /home/ehsan/moz/src/xpcom/ds/nsTArray.h:557
#9  0x00007fcda7c767a6 in nsTArray_Impl<nsAutoPtr<nsComponentManagerImpl::KnownModule>, nsTArrayInfallibleAllocator>::DestructRange(unsigned long, unsigned long) (this=0x7fcdbc592cf8, aStart=0, aCount=59)
    at /home/ehsan/moz/src/xpcom/ds/nsTArray.h:2350
#10 0x00007fcda7c7672e in nsTArray_Impl<nsAutoPtr<nsComponentManagerImpl::KnownModule>, nsTArrayInfallibleAllocator>::ClearAndRetainStorage() (this=0x7fcdbc592cf8)
    at /home/ehsan/moz/src/xpcom/ds/nsTArray.h:1382
#11 0x00007fcda7c73419 in nsTArray_Impl<nsAutoPtr<nsComponentManagerImpl::KnownModule>, nsTArrayInfallibleAllocator>::Clear() (this=0x7fcdbc592cf8) at /home/ehsan/moz/src/xpcom/ds/nsTArray.h:1895
#12 0x00007fcda7c6c48e in nsComponentManagerImpl::Shutdown() (this=0x7fcdbc592c10) at /home/ehsan/moz/src/xpcom/components/nsComponentManager.cpp:845
#13 0x00007fcda7d1e10a in mozilla::ShutdownXPCOM(nsIServiceManager*) (aServMgr=0x0) at /home/ehsan/moz/src/xpcom/build/XPCOMInit.cpp:1020
#14 0x00007fcda7d1da75 in NS_ShutdownXPCOM(nsIServiceManager*) (aServMgr=0x7fcdbc592c18) at /home/ehsan/moz/src/xpcom/build/XPCOMInit.cpp:820
#15 0x00007fcdaf16d66f in ScopedXPCOMStartup::~ScopedXPCOMStartup() (this=0x7fcda0596478) at /home/ehsan/moz/src/toolkit/xre/nsAppRunner.cpp:1429
#16 0x00007fcdaf17de9b in mozilla::DefaultDelete<ScopedXPCOMStartup>::operator()(ScopedXPCOMStartup*) const (this=0x7ffc95334460, aPtr=0x7fcda0596478)
    at /home/ehsan/moz/src/obj-ff-clang-plugin.noindex/dist/include/mozilla/UniquePtr.h:528
#17 0x00007fcdaf17de1f in mozilla::UniquePtr<ScopedXPCOMStartup, mozilla::DefaultDelete<ScopedXPCOMStartup> >::reset(ScopedXPCOMStartup*) (this=0x7ffc95334460, aPtr=0x0)
    at /home/ehsan/moz/src/obj-ff-clang-plugin.noindex/dist/include/mozilla/UniquePtr.h:343
#18 0x00007fcdaf17c777 in mozilla::UniquePtr<ScopedXPCOMStartup, mozilla::DefaultDelete<ScopedXPCOMStartup> >::operator=(decltype(nullptr)) (this=0x7ffc95334460)
    at /home/ehsan/moz/src/obj-ff-clang-plugin.noindex/dist/include/mozilla/UniquePtr.h:313
#19 0x00007fcdaf178d99 in XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) (this=0x7ffc953343f0, argc=5, argv=0x7ffc953357a8, aConfig=...) at /home/ehsan/moz/src/toolkit/xre/nsAppRunner.cpp:4957
#20 0x00007fcdaf179559 in XRE_main(int, char**, mozilla::BootstrapConfig const&) (argc=5, argv=0x7ffc953357a8, aConfig=...) at /home/ehsan/moz/src/toolkit/xre/nsAppRunner.cpp:5021
#21 0x00007fcdaf190bb7 in mozilla::BootstrapImpl::XRE_main(int, char**, mozilla::BootstrapConfig const&) (this=0x7fcdbc54a6a0, argc=5, argv=0x7ffc953357a8, aConfig=...)
    at /home/ehsan/moz/src/toolkit/xre/Bootstrap.cpp:49
#22 0x0000558c1c1c8726 in do_main(int, char**, char**) (argc=5, argv=0x7ffc953357a8, envp=0x7ffc953357d8) at /home/ehsan/moz/src/browser/app/nsBrowserApp.cpp:237
#23 0x0000558c1c1c82fb in main(int, char**, char**) (argc=5, argv=0x7ffc953357a8, envp=0x7ffc953357d8) at /home/ehsan/moz/src/browser/app/nsBrowserApp.cpp:329

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/788fc36dbdad
Remove the XPCOM registration for nsErrorService; r=froydnj

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/788fc36dbdad