Closed
Bug 1504597
Opened 6 years ago
Closed 6 years ago
[BinAST] Use NodeName::to_rc_string
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
Details
Attachments
(1 file)
|
13.29 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
callsites of string_from_nodename in main.rs should be rewritten to use NodeName::to_rc_string.
|
Assignee | |
Comment 1•6 years ago
|
||
Removed string_from_nodename and fixed callsites to use .to_rc_string().clone()
Comment on attachment 9022504 [details] [diff] [review] Use NodeName::to_rc_string. Review of attachment 9022504 [details] [diff] [review]: ----------------------------------------------------------------- lgtm Apologies for the slow review. Privacy Badger wouldn't let me log to Bugzilla.
Attachment #9022504 -
Flags: review?(dteller) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/274f95b85267d07ae0d2eceb95c683dda098ce82 Bug 1504597 - Use NodeName::to_rc_string. r=Yoric
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/274f95b85267
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•