Closed Bug 1504681 Opened 4 years ago Closed 4 years ago

Cleanup inspector preferences set from DAMP tests

Categories

(DevTools :: General, enhancement, P3)

enhancement

Tracking

(firefox65 fixed)

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

Details

Attachments

(1 file)

DAMP is setting two preferences:

- "devtools.inspector.show-three-pane-tooltip"=false
https://searchfox.org/mozilla-central/rev/efc0d9172cb6a5849c6c4fc0f19d7fd5a2da9643/testing/talos/talos/tests/devtools/addon/content/damp.js#77

- "devtools.inspector.activeSidebar"="layoutview"
https://searchfox.org/mozilla-central/rev/efc0d9172cb6a5849c6c4fc0f19d7fd5a2da9643/testing/talos/talos/tests/devtools/addon/content/tests/inspector/layout.js#20

First one is no longer used so should be removed. The second one can be removed since it's the default value. But since the test is about testing the layout view, I think it's better tobe explicit and keep it.
There's a potential upcoming split of the "layoutview" into its sub-components (grid inspector, flexbox inspector, box model). 

Agreed, it's best to keep that second pref, "devtools.inspector.activeSidebar"="layoutview", either for continuity or a reminder when/if the panel gets split.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d6aefc121d0c
Stop setting unused preferences in DAMP tests;r=ochameau
https://hg.mozilla.org/mozilla-central/rev/d6aefc121d0c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Assignee: nobody → jdescottes
You need to log in before you can comment on or make changes to this bug.