Closed
Bug 1504706
Opened 6 years ago
Closed 6 years ago
Call Toolbox.destroy instead of gDevTools.closeToolbox when using having a toolbox object around
Categories
(DevTools :: Framework, enhancement, P3)
DevTools
Framework
Tracking
(firefox65 fixed)
RESOLVED
FIXED
Firefox 65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
A couple of places: https://searchfox.org/mozilla-central/search?q=gDevTools.closeToolbox&case=false®exp=false&path= are calling `gDevTools.closeToolbox(target)`, whereas they are having a `toolbox` object offhand. Instead they can simply call `toolbox.destroy()` as gDevTools.closeToolbox is just an alias to it: https://searchfox.org/mozilla-central/source/devtools/client/framework/devtools.js#586
|
Assignee | |
Comment 1•6 years ago
|
||
MozReview-Commit-ID: FcAItxuKWIk
|
|
Assignee | |
Comment 2•6 years ago
|
||
Green try: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=209853787&revision=e00bb74d63f6d5e4b0601da80a1bede027b69a35 The test verify failure is related to bug 1499994.
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e6e2b400168a Call toolbox.destroy instead of going throught gDevTools.closeToolbox. r=yulia
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e6e2b400168a
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in
before you can comment on or make changes to this bug.
Description
•