150471 - Clicking OK does nothing after editing advanced options

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[David Rahrer]

From main Mail client window, choose Edit > Mail & Newsgroups Account Settings >
Outgoing Server (SMTP).  Click on the Advanced button on the right and edit the
advanced settings in some way.  "OK" out of the Advanced Settings window and the
click "OK" to close the main Mail & Newgroups Account Settings window and
nothing happens.  This same button works fine as long as these Advanced Settings
have not been edited during the session.  This button also works fine if the
same Advanced Settings are edited on another account than the Outgoing Server
(SMTP).  

Clicking "Cancel" instead of "OK" is a workaround.

Comment 1

[Christian Eyrich]

Can confirm this on Win95 and Linux with 1.1a builds 20020612 (sadly I've not
the permission to change Status).

Comment 2

[R.K.Aa.]

similar/dup: bug 157461

Comment 3

[R.K.Aa.]

*** Bug 156334 has been marked as a duplicate of this bug. ***

Comment 4

[R.K.Aa.]

*** Bug 157461 has been marked as a duplicate of this bug. ***

Comment 5

[R.K.Aa.]

*** Bug 153687 has been marked as a duplicate of this bug. ***

Comment 6

[R.K.Aa.]

Resolving as NEW based on dups.

Comment 7

[R.K.Aa.]

*** Bug 151272 has been marked as a duplicate of this bug. ***

Comment 8

[R.K.Aa.]

Can we get a confirmation that this is still a bug? It hasn't been submitted for
a while, and i am unable to reproduce on a new build on Linux.

Are you all still seeing the bug with current builds?

Comment 9

[Arkady Sherman]

to R.K.Aa.
Yes, it has still been present in build 2002072208 on win 2000. I believe that's
a bug on win2k only.
         With best wishes, Arkady Sherman
  

Comment 10

[Jean-Pierre Melkonian]

It is not a win2k bug
I have the same on Mac OS 9.1 Build 2002072908
see dup bug 156334

Comment 11

[R.K.Aa.]

raising severity

Comment 12

[R.K.Aa.]

bug 160157 is also partly a dup of this.

Comment 13

[R.K.Aa.]

*** Bug 160273 has been marked as a duplicate of this bug. ***

Comment 14

[gabriel]

I noticed this yesterday on 1.1b Linux.

Comment 15

[R.K.Aa.]

this is late.. but nominating

when i hit the "edit" button in advanced, after having selected a smtp server, i
see this in js console:

Error: gPrefBranch is not defined
Source File: chrome://messenger/content/smtpEditOverlay.js
Line: 94

Comment 16

[R.K.Aa.]

in a week old debug build, linux, i can reproduce this without actually editing
anything. Just:

open  mailnews accounts settings
select smtp server -> advanced
click existing server (to select) and hit "edit" button
-The JS error mentioned in comment 15 appears
Click OK on edit button without changing anything - that dialog will dismiss ok
Click OK on smtp advanced window: that window too will dismiss

Now click the OK button of the preferences window:
Nothing happens (which is this bug.)

The debug build at this point displays:
WARNING: NS_ENSURE_TRUE(presShell) failed, file nsGenericHTMLElement.cpp, line 3014

Now click the "Cancel" button instead, this appears and the window will dismiss:
WARNING: DropTimeout proceeding without context., file nsGlobalWindow.cpp, line 4752

Comment 17

[racham]

Attachment: patch, v1.0

Comment 18

[R.K.Aa.]

*** Bug 161420 has been marked as a duplicate of this bug. ***

Comment 19

[R.K.Aa.]

Built with the patch in attachment 94116 [details] [diff] [review] on Linux -
As far as i can judge, it does just the right thing:

-The JS warning in comment 15 is gone.
-I can modify smtp server name in mail & newsgroup account
settings/advanced/edit, and afterwards OK my way all the way out of the various
windows.
-The servername gets changed to what i change it to.

Comment 20

[(not reading, please use [e-mail] instead)]

Comment on attachment 94116 [details] [diff] [review]
patch, v1.0

sr=sspitzer

Comment 21

[Srilatha Moturi]

Comment on attachment 94116 [details] [diff] [review]
patch, v1.0

r=srilatha

Comment 22

[racham]

*** Bug 162016 has been marked as a duplicate of this bug. ***

Comment 23

[racham]

Fix checked in.

I will check on the branch and add nsbeta1 keyword, if needed.

Comment 24

[Jean-Pierre Melkonian]

Now works for me. MacOS 9.1 Build 2002081113

Comment 25

[Steve Wardell]

Still having problems in 2002081108 on XP (with or without editing any of the
advanced settings). Go into advance settings, click ok (window closes), click ok
on main mail / news config (window doesn't close) and I get this:

Error: invalid 'in' operand accountValues
Source File: chrome://messenger/content/AccountManager.js
Line: 243

Comment 26

[racham]

I have noticed that branch builds are working just fine by closing the
AcountManager window properly when clicked on OK button after editing/opening
the SMTp advanced panel. Ninoschka, can you confirm this ? Thanks.

Comment 27

[Steve Wardell]

I just got what I mentioned in Comment 25 in 2002081204 on W2K. Still seems to
be a problem.

Comment 28

[R.K.Aa.]

*** Bug 165509 has been marked as a duplicate of this bug. ***

Comment 29

[Rack]

*** Bug 166070 has been marked as a duplicate of this bug. ***

Comment 30

[R.K.Aa.]

*** Bug 176075 has been marked as a duplicate of this bug. ***

Comment 31

[R.K.Aa.]

*** Bug 171207 has been marked as a duplicate of this bug. ***

Comment 32

[R.K.Aa.]

*** Bug 178056 has been marked as a duplicate of this bug. ***

Comment 33

[R.K.Aa.]

*** Bug 183001 has been marked as a duplicate of this bug. ***

Comment 34

[R.K.Aa.]

*** Bug 173841 has been marked as a duplicate of this bug. ***

Comment 35

[R.K.Aa.]

*** Bug 177235 has been marked as a duplicate of this bug. ***

Comment 36

[R.K.Aa.]

*** Bug 167564 has been marked as a duplicate of this bug. ***

Comment 37

[Ninoschka Baca]

Trunk build 2003-04-24: Mac 10.1.5, Linux RH 8
Trunk build 2003-04-23: WinXP
Verified Fixed.