Closed Bug 1504711 Opened 6 years ago Closed 5 years ago

Invalid conditional in auto-classify toolbar

Categories

(Tree Management :: Treeherder, enhancement)

Product:
Tree Management
Component:
Treeherder
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: emorley, Unassigned)

References

Details

Found via ESLint, this `status === 'ready'` conditional is buggy: https://github.com/mozilla/treeherder/blob/bcf09f2cfa7d673f54b738eed4d1b11ba8918582/ui/job-view/details/tabs/autoclassify/AutoclassifyToolbar.jsx#L29-L32 We never define `status`, so it is accidentally using `window.status`, which is the browser status bar text. Perhaps it's meant to be `autoclassifyStatus` instead? Although even then it doesn't make sense unless the conditional is also inverted.
See Also: → 1505758

There is currently no work on autoclassification and its panel. Removing priority.

Priority: P2 → --
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
Component: Treeherder: Log Parsing & Classification → TreeHerder
You need to log in before you can comment on or make changes to this bug.