1504792 - fxdevtools-adapters and adbhelper add-ons still serve RDF update manifests

Status: NEW

(DevTools :: General, enhancement, P3)

Description

[Kris Maglione [:kmag]]

Support for RDF update manifests is deprecated, and being removed. However, devtools add-ons have update URLs which are still serving RDF manifests. If we need these to keep working, they need to migrate to serving JSON manifests instead.

Comment 1

[Julian Descottes [:jdescottes]]

fxdevtools-adapters is valence which is no longer supported.
adbhelper is also no longer supported as of Firefox 63.

Do we need to do something here? Should we remove the RDF located at the update URL? I assume we want to keep them around for ESR versions that still support them (at least for ADB Helper).

Comment 2

[Kris Maglione [:kmag]]

I guess we should delete the update manifest after we stop supporting the latest ESR that supports these add-ons. Ideally, we should also make sure they get uninstalled from any newer Firefox versions that don't support them.

Comment 3

[Julian Descottes [:jdescottes]]

For the record we have some logic that removes ADB Helper when the module responsible for installing its webextension replacement starts https://searchfox.org/mozilla-central/rev/6e0e603f4852b8e571e5b8ae133e772b18b6016e/devtools/shared/adb/adb-addon.js#44-45

We didn't do anything for Valence though. I'm happy to modify this code to also remove Valence, but maybe there is a more centralized place to do that, that doesn't need to go into devtools?

Comment 4

[Kris Maglione [:kmag]]

(In reply to Julian Descottes [:jdescottes][:julian] from comment #3)
> For the record we have some logic that removes ADB Helper when the module
> responsible for installing its webextension replacement starts
> https://searchfox.org/mozilla-central/rev/
> 6e0e603f4852b8e571e5b8ae133e772b18b6016e/devtools/shared/adb/adb-addon.js#44-
> 45

Great

> We didn't do anything for Valence though. I'm happy to modify this code to
> also remove Valence, but maybe there is a more centralized place to do that,
> that doesn't need to go into devtools?

That would probably be a good idea. We don't have a centralized place to handle such things.