Status

SeaMonkey
Page Info
--
trivial
RESOLVED WONTFIX
16 years ago
13 years ago

People

(Reporter: Christophe Thalet, Assigned: db48x)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

16 years ago
in "Page Info" dialog on tab "General":
why is there a ":" after the title of the page
which gets its info displayed? I would like to have it removed
and see the original title of the page only
-> Page Info
Assignee: Matti → db48x
Component: Browser-General → Page Info
QA Contact: imajes-qa → pmac
(Assignee)

Comment 2

16 years ago
sure, whatever. Actually, this might get fixed sooner if you were to submit a 
patch for it.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows NT → All
Hardware: PC → All

Comment 3

16 years ago
File to change is pageinfo.properties

Line 28:

- pageTitle=%S:
+ pageTitle=%S


Works fine for me after one day of testing...
r and sr, anyone?

(btw, my first code related comment in Bugzilla, so please don't beat me :)
(Assignee)

Comment 4

16 years ago
That would certainly do it. Actually though, a more efficient approach would be 
to delete the string from the .properties file, and modify pageInfo.js so that 
it doesn't look it up and just inserts the title into the textbox as is. That'd 
be line 188, just take out the call to getFormattedString, leaving 
theDocument.title.

Then, all you have to do is attach a patch, and you're set. :)

Comment 5

16 years ago
Created attachment 87230 [details] [diff] [review]
Patch for Pageinfo.js

Comment 6

16 years ago
Created attachment 87232 [details] [diff] [review]
Patch for Pageinfo.properties

Comment 7

16 years ago
Beware! 
I created these diffs via the "diff"-command under Windows (coming with WinCVS
1.2) and attachment 87230 [details] [diff] [review] refers to two files with different names (original is
pageinfo.js, new version pageinfoneu.js)!

Comment 8

16 years ago
Seeking review, as patches work for me.

Updated

16 years ago
Keywords: patch, review

Comment 9

16 years ago
Is this really a problem?  All of the other bold section headers in the window 
end with colons.  If you nuke the colon after the page title and none of the 
other colons, it'll be somewhat inconsistent...

If you really want that colon gone, it seems like it would be better to do 
something like (forgive the pseudo-HTML):

<b>Page Information:</b>
Title:           Getting Involved with mozilla.org
URL:             http://www.mozilla.org/start/
Type:            text/html
        (etc.)
(Assignee)

Comment 10

16 years ago
This doesn't really need to be fixed. Nothing wrong with the patch though.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → WONTFIX
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.