150483 - please remove ":"

Status: RESOLVED WONTFIX

(SeaMonkey :: Page Info, defect)

Description

[Christophe Thalet]

in "Page Info" dialog on tab "General":
why is there a ":" after the title of the page
which gets its info displayed? I would like to have it removed
and see the original title of the page only

Comment 1

[Matthias Versen [:Matti]]

-> Page Info

Comment 2

[Daniel Brooks [:db48x]]

sure, whatever. Actually, this might get fixed sooner if you were to submit a 
patch for it.

Comment 3

[Junk_HbJ]

File to change is pageinfo.properties

Line 28:

- pageTitle=%S:
+ pageTitle=%S


Works fine for me after one day of testing...
r and sr, anyone?

(btw, my first code related comment in Bugzilla, so please don't beat me :)

Comment 4

[Daniel Brooks [:db48x]]

That would certainly do it. Actually though, a more efficient approach would be 
to delete the string from the .properties file, and modify pageInfo.js so that 
it doesn't look it up and just inserts the title into the textbox as is. That'd 
be line 188, just take out the call to getFormattedString, leaving 
theDocument.title.

Then, all you have to do is attach a patch, and you're set. :)

Comment 5

[Junk_HbJ]

Attachment: Patch for Pageinfo.js

Comment 6

[Junk_HbJ]

Attachment: Patch for Pageinfo.properties

Comment 7

[Junk_HbJ]

Beware! 
I created these diffs via the "diff"-command under Windows (coming with WinCVS
1.2) and attachment 87230 [details] [diff] [review] refers to two files with different names (original is
pageinfo.js, new version pageinfoneu.js)!

Comment 8

[Junk_HbJ]

Seeking review, as patches work for me.

Comment 9

[Richard Godbee]

Is this really a problem?  All of the other bold section headers in the window 
end with colons.  If you nuke the colon after the page title and none of the 
other colons, it'll be somewhat inconsistent...

If you really want that colon gone, it seems like it would be better to do 
something like (forgive the pseudo-HTML):

<b>Page Information:</b>
Title:           Getting Involved with mozilla.org
URL:             http://www.mozilla.org/start/
Type:            text/html
        (etc.)

Comment 10

[Daniel Brooks [:db48x]]

This doesn't really need to be fixed. Nothing wrong with the patch though.