1504840 - Blue "unseen" indicator on folders makes the folder name unreadable in Mojave Dark Mode

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Dave Miller [:justdave]]

With the Mojave OS set to Dark Mode, the blue "unseen" folder names are unreadable in the folder list, because the dark blue blends in with the dark background.  I suggest when in Dark Mode the folder names should be a brighter blue color to provide a little more contrast (just like the other folder names become white instead of black when in dark mode).  The blue when not in Dark Mode is fine how it is.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1504840-newMail-blue.patch

Based on the tab tree line blue but made lighter to be better visible.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: newMail.png

Hoe it looks with the patch.

Comment 3

[Dave Miller [:justdave]]

indeed, much better. :)

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 9023053 [details] [diff] [review]
1504840-newMail-blue.patch

OK. Not easy to find a "blue" folder to start with.

Why do you need uplift to ESR 60? As far as I can see, the folder tree in the dark theme isn't dark.

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9023053 [details] [diff] [review]
1504840-newMail-blue.patch

Ah yes. I was used to set ESR too. :-(

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c7f02af5ea18
Use a light blue "New mail indication" with dark theme. r=jorgk

Comment 7

[Jorg K (CEST = GMT+2)]

Beta (TB 64 beta 2):
https://hg.mozilla.org/releases/comm-beta/rev/4f1a2ba79d6dc7bdaf1ad72928044b6b6f867db1

Comment 8

[Dave Miller [:justdave]]

This got regressed... it's broken again in 68.0b1 Build ID 20190613171710

Comment 9

[Richard Marti (:Paenglab)]

Please don't reopen a fixed bug. Create a new for a regression.

More information would be helpful. Do you use the default TB theme with dark OS theme? If yes, could you try to enable the dark TB theme? When this fixes the issue, it's bug 1540515 that regresses.

Comment 10

[Dave Miller [:justdave]]

Yeah, explicitly setting the dark theme does resolve it. Will go add myself to bug 1540515 then. Thanks!