eslint: Restrict usage of the event global

RESOLVED FIXED in Firefox 65

Status

enhancement
P1
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: mstriemer, Assigned: mstriemer)

Tracking

65 Branch
mozilla65

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(2 attachments)

In bug 1493869 the `event` global was restricted to only being available on Nightly, if you accidentally use it then your code will work until it hits Beta.

Marionette uses an event global a lot, but I believe it defines its own event object.

There are two other spots where restricting the event global will fail, one is certainly a bug and should now be fixed (bug 1504725) and another I just identified and I'm not sure if it's a bug (bug 1496782).

Test try run: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=209954214&revision=d5cd858f8abfb55ce1be6746800653e7122f98ee
The event global is only available on Nightly so it should not be used.
The about:performance case is fixed in bug 1505031, this should be okay to land now.

Mark, does it seem okay to land this now? I'm not sure of the process for new rules like this.
Flags: needinfo?(standard8)
I think this is fine to deploy now. At this stage it is really a correctness issue to stop mistakes than a policy.

Can you just modify the version number at the top of:

- tools/lint/eslint/eslint-plugin-mozilla/package.json
- tools/lint/eslint/eslint-plugin-mozilla/package-lock.json

Just bumping from "0.16.1" to "0.16.2" will be fine, it lets me publish a new version.
Flags: needinfo?(standard8)
Summary: Restrict usage of the event global → eslint: Restrict usage of the event global
Yes please.
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/527bceeb871a
Restrict usage of event global r=Standard8,ahal
https://hg.mozilla.org/mozilla-central/rev/527bceeb871a
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
See Also: → 1504725, 1505031
You need to log in before you can comment on or make changes to this bug.