1504890 - eslint: Restrict usage of the event global

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement, P1)

Description

[Mark Striemer [:mstriemer]]

In bug 1493869 the `event` global was restricted to only being available on Nightly, if you accidentally use it then your code will work until it hits Beta.

Marionette uses an event global a lot, but I believe it defines its own event object.

There are two other spots where restricting the event global will fail, one is certainly a bug and should now be fixed (bug 1504725) and another I just identified and I'm not sure if it's a bug (bug 1496782).

Test try run: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=209954214&revision=d5cd858f8abfb55ce1be6746800653e7122f98ee

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1504890 - Restrict usage of event global

The event global is only available on Nightly so it should not be used.

Comment 2

[Mark Striemer [:mstriemer]]

The about:performance case is fixed in bug 1505031, this should be okay to land now.

Mark, does it seem okay to land this now? I'm not sure of the process for new rules like this.

Comment 3

[Mark Banner (:standard8)]

I think this is fine to deploy now. At this stage it is really a correctness issue to stop mistakes than a policy.

Can you just modify the version number at the top of:

- tools/lint/eslint/eslint-plugin-mozilla/package.json
- tools/lint/eslint/eslint-plugin-mozilla/package-lock.json

Just bumping from "0.16.1" to "0.16.2" will be fine, it lets me publish a new version.

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: Bug 1504890 - Bump eslint-plugin-mozilla version r?Standard8

Comment 5

[Mike Taylor [:miketaylr]]

Yes please.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/527bceeb871a
Restrict usage of event global r=Standard8,ahal

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/527bceeb871a