1504909 - Include current execution point and recording endpoint in pause packets

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, defect)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

When a thread actor pauses it includes an execution point for where it is paused at, but this reflects the last console message instead of where the thread currently is.  The attached patch changes this so that the exact location of the pause is included in this packet.  The recording endpoint is also specified in the packet, which the devtools client can use for setting the scale of the timeline.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: Part 1 - Include current point and endpoint in paused packets.

Changes to the debugger server and replaying process JS to include the current point and recording endpoint in paused packets.

Comment 2

[Brian Hackett [Laid off!]]

Attachment: Part 2 - Remove unused recordingPosition interface.

Remove the now-unused interface to get the recording position as a fraction in the [0,1] range.

Comment 3

[Brian Hackett [Laid off!]]

Attachment: Part 3 - Get the current point and recording endpoint from navigation state.

Information about the bounds of the recording and the current position within the recording is stored by the navigation state in toolkit/recordreplay/ipc/ChildNavigation.cpp.  This patch extends some existing interfaces in this code so that the JS bindings can access this information.

Comment 4

[Brian Hackett [Laid off!]]

Attachment: Part 4 - Always store progress counter in execution points.

Currently, ExecutionPoint does not specify a progress counter for points which coincide with checkpoints.  This isn't very useful for easily determining where a given ExecutionPoint should go on the timeline.  This patch simplifies things for the devtools JS by just always including the progress counter in an ExecutionPoint.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/42475558ccac
Part 1 - Include current point and endpoint in paused packets, r=lsmyth.
https://hg.mozilla.org/integration/mozilla-inbound/rev/669dca3ed43c
Part 2 - Remove unused recordingPosition interface, r=lsmyth.
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f33aed589e1
Part 3 - Get the current point and recording endpoint from navigation state, r=lsmyth.
https://hg.mozilla.org/integration/mozilla-inbound/rev/aec161975269
Part 4 - Always store progress counter in execution points, r=lsmyth.

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/42475558ccac
https://hg.mozilla.org/mozilla-central/rev/669dca3ed43c
https://hg.mozilla.org/mozilla-central/rev/8f33aed589e1
https://hg.mozilla.org/mozilla-central/rev/aec161975269