Closed
Bug 1504986
Opened 6 years ago
Closed 6 years ago
Port Bug 1504574 - Remove the XPCOM registration for nsDocumentEncoder
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 65.0
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
Details
Attachments
(1 file, 1 obsolete file)
4.30 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
We use this a few times: https://searchfox.org/comm-central/search?q=documentEncoder%3B1%3Ftype%3D&case=false®exp=false&path= and here's the replacement: https://hg.mozilla.org/mozilla-central/rev/2aaf8a7930e5#l1.12
Assignee | ||
Comment 1•6 years ago
|
||
Without warranty, local compile hasn't finished.
Attachment #9022886 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Comment 2•6 years ago
|
||
Added error checking. I guess it's not necessary, but better than a crash.
Attachment #9022886 -
Attachment is obsolete: true
Attachment #9022886 -
Flags: review?(mkmelin+mozilla)
Attachment #9022888 -
Flags: review?(mkmelin+mozilla)
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/066cb8e1041f Port bug 1504574: replace XPCOM use of nsDocumentEncoder. rs-bustage-fix
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment 4•6 years ago
|
||
Comment on attachment 9022888 [details] [diff] [review] 1504986-nsDocumentEncoder.patch (v1b) Review of attachment 9022888 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, r=mkmelin
Attachment #9022888 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 65.0
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•