1504989 - Perma nsFrameLoader.cpp error: unused function 'CheckDocShellType' when Gecko 65 merges to Beta on 2018-12-03

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Raul Gurzau (:RaulG)]

[Tracking Requested - why for this release]:

Central as Beta Simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=000d37e6261f0ed96d4edd2c968a8b5144ad672a&selectedJob=210023374

Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=210029194&repo=try&lineNumber=23307

Log snippet: 

task 2018-11-06T11:29:09.505Z] 11:29:09     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/dom/base/Unified_cpp_dom_base7.cpp:38:
[task 2018-11-06T11:29:09.505Z] 11:29:09     INFO -  /builds/worker/workspace/build/src/dom/base/nsFrameLoader.cpp:566:1: error: unused function 'CheckDocShellType' [-Werror,-Wunused-function]
[task 2018-11-06T11:29:09.505Z] 11:29:09     INFO -  CheckDocShellType(mozilla::dom::Element* aOwnerContent,
[task 2018-11-06T11:29:09.505Z] 11:29:09     INFO -  ^
[task 2018-11-06T11:29:09.505Z] 11:29:09     INFO -  1 error generated.
[task 2018-11-06T11:29:09.505Z] 11:29:09     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1126: recipe for target 'Unified_cpp_dom_base7.o' failed
[task 2018-11-06T11:29:09.505Z] 11:29:09     INFO -  make[4]: *** [Unified_cpp_dom_base7.o] Error 1
[task 2018-11-06T11:29:09.505Z] 11:29:09     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/base'
[task 2018-11-06T11:29:09.505Z] 11:29:09     INFO -  make[4]: *** Waiting for unfinished jobs....
[task 2018-11-06T11:29:09.505Z] 11:29:09     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/media'

Comment 1

[Raul Gurzau (:RaulG)]

Hi, can you please take a look at this?

Comment 2

[Andreas Farre [:farre]]

Attachment: Bug 1504989 - Add ifdef for nightly only function.

Comment 3

[Raul Gurzau (:RaulG)]

Backing out Bug 1480198 resolved the issue: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&revision=69ca4a653dd7e1bbace15bdf20fd4904a8da0a2b&selectedJob=210045207

Comment 4

[Andreas Farre [:farre]]

Fix in queue for review at https://phabricator.services.mozilla.com/D11045

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/071d5917ee35
Add ifdef for nightly only function. r=peterv

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/071d5917ee35

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with today's beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=667ddffc382ff2864cd02d4bd4d2f25c4e74dd85