1505028 - TelemetrySend.reset() doesn't reset TelemetrySend adequately for tests, resulting in noise

Status: NEW

(Toolkit :: Telemetry, enhancement, P3)

Description

[Chris H-C :chutten]

There are quite a few stack traces when running test_TelemetrySend. Some are to be expected because we're testing how things fail (though they could check _testingMode and be a little quieter), but a lot are complaining about removing observers that were never registered.

This is because though the tests shut things down properly, many just call TelemetrySend.reset() to start things up again. That's not enough to register the observers, so the next time we get shut down we complain again.

Right now this is just noise in the logs. Annoying, but survivable.

However, having two separate setup mechanisms might result in odd test failures because we failed to account for one or another piece of state that needed setting up properly.

This bug is for looking into TelemetrySend's state, how it is used in tests, and how we might rearchitect things so they're quieter and less prone to stubbed toes.

Comment 1

[Chris H-C :chutten]

Dropping to P3 since this is a test-only method that only the Telemetry tests call.