1505046 - Commandeering could do with improvements for the "fix minor bitrot" case

Status: NEW

(Conduit :: Phabricator, enhancement, P3)

Description

[Mark Banner (:standard8)]

I just had the case where a patch sequence had already had multiple revisions, and had just been rebased, but needed another rebase due to items landing in-between the first rebase and the second.

Seeing as this was a first time contributor (no commit access) with a large patch, and not always available at the same times as me, I thought I would "Commandeer" the patch, fix the bitrot and push it straight away.

However:

- Commandeering means I now own the patch, this is ok (side note: it isn't clear from the Phab UI that the commit information still has the original author as the author, only lando told me that).

- As I now am author of the revision, I can't be a reviewer for the patch, even if I've already granted review previously.

- Hence, my review no longer stands on the committed result.

Thankfully in this case, someone else had already reviewed it alongside me.

Comment 1

[Mark Côté [:mcote]]

Yeah this is a bit of a productivity papercut in some situations.  I'm not sure if this is something we should try to get upstream to fix or something we can work around, maybe in Lando.