Closed
Bug 1505088
Opened 6 years ago
Closed 5 years ago
Fuzzy time monotonicity checked twice on Windows
Categories
(Core :: JavaScript Engine, defect, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla66
People
(Reporter: anba, Assigned: tjr)
References
Details
Attachments
(1 file, 1 obsolete file)
The fuzzy time monotonicity check should only be applied here [1], but on Windows it's also checked at [2]. [1] https://searchfox.org/mozilla-central/rev/b096dcf0ea226af628fe03f7e7acb56a25853533/js/src/vm/Time.cpp#57-59 [2] https://searchfox.org/mozilla-central/rev/b096dcf0ea226af628fe03f7e7acb56a25853533/js/src/vm/Time.cpp#177-179
|
||
Comment 1•6 years ago
|
||
CC-ing Tom, as he might want to review this code once done.
Priority: -- → P3
|
|
||
Updated•6 years ago
|
Flags: needinfo?(tom)
|
Assignee | |
Comment 4•6 years ago
|
||
|
Reporter | |
Comment 5•5 years ago
|
||
Comment on attachment 9025418 [details] [diff] [review] Bug 1505088 - Remove redundant call and comparison to NowFuzzyTime in JS Engine r?anba Review of attachment 9025418 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #9025418 -
Flags: review?(andrebargull) → review+
|
|
Assignee | |
Comment 6•5 years ago
|
||
Carry forward r+ from Comment 5
Attachment #9025418 -
Attachment is obsolete: true
Attachment #9031537 -
Flags: review+
|
|
Assignee | |
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/15cd66da94ea Remove redundant call and comparison to NowFuzzyTime in JS Engine. r=anba
Keywords: checkin-needed
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/15cd66da94ea
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
|
||
Comment 9•5 years ago
|
||
Is this something we should consider backporting to Beta? Please nominate it if so.
Flags: needinfo?(tom)
|
|
Assignee | |
Comment 10•5 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #9) > Is this something we should consider backporting to Beta? Please nominate it > if so. Nah, this is just a correctness fix, it won't affect behavior.
Flags: needinfo?(tom)
|
|
||
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•