1505101 - Try push output no longer contains link

Status: RESOLVED WORKSFORME

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Botond Ballo [:botond]]

STR:
  Push to try

Expected results:
  Command-line output contains link to the try push.

Actual results:
  It does not. The output is now only:

================
pushing to ssh://hg.mozilla.org/try
Enter passphrase for key '/home/botond/.ssh/id_mozilla': 
searching for changes
remote: adding changesets                                                                                                                                                   
remote: adding manifests
remote: adding file changes
remote: added 2 changesets with 2 changes to 2 files (+1 heads)
remote: recorded push in pushlog
================

This is a recent regression.

Comment 1

[Andrew Halberstadt [:ahal]]

On the latest central I see:

pushing to ssh://hg.mozilla.org/try
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 0 changes to 1 files (+1 heads)
remote: recorded push in pushlog
remote: 
remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/ac5a81e0c05f047ce722a0ab6c900134fd7d94e4
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac5a81e0c05f047ce722a0ab6c900134fd7d94e4
remote: recorded changegroup in replication log in 0.025s
push complete


Could you be more specific please? Is this with hg or git? With mach or pushing directly?

Comment 2

[Botond Ballo [:botond]]

(In reply to Andrew Halberstadt [:ahal] from comment #1)
> Could you be more specific please? Is this with hg or git? With mach or
> pushing directly?

With hg, pushing directly.

Comment 3

[Andrew Halberstadt [:ahal]]

(I also have an up-to-date version-control-tools fwiw)

Comment 4

[Andrew Halberstadt [:ahal]]

I still see the links when pushing with hg directly, so not sure what's going on. Out of curiosity does this still happen with mach?

Either way, it sounds like this is more of an issue on the hg.m.o side of things.

Comment 5

[Botond Ballo [:botond]]

I tried updating version-control-tools; that did not help.

I also tried using |mach try|, and that did not help either. Here is the complete output of |mach try|:

$ ./mach try -b do -p android-api-16,android-x86 -u mochitests -t none
Creating temporary commit for remote...
pushing to ssh://hg.mozilla.org/try
Enter passphrase for key '/home/botond/.ssh/id_mozilla':
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 2 changesets with 3 changes to 5 files (+1 heads)
remote: recorded push in pushlog
push complete
temporary commit removed, repository restored
$

Comment 6

[Gregory Szorc [:gps]]

This happened before the hg.mo Mercurial 4.8 upgrade yesterday. So not due to that.

It could be a regression from the Mercurial 4.7 upgrade, which went out on October 29 IIRC.

It is possible there is a race condition of sorts involving buffer flushes. Python hooks are supposed to write output using ui.write() and this hook does do that. It is quite possible upstream Mercurial dropped a necessary flush() somewhere to propagate buffered hook output. There have historically been a handful of bugs in this area...

Another somewhat recent change in Mercurial's behavior is where "remote:" output is sent. I believe it has changed between stderr/stdout depending on Mercurial version or use of bundle2. But stock `hg` should "just work."

botond: could you please perform a push with `HGRCPATH= hg push` (you may need to tack on some --config options to restore some auth settings) so we can confirm this is a bug with vanilla Mercurial (and not something introduced by an extension)?

Comment 7

[Botond Ballo [:botond]]

(In reply to Gregory Szorc [:gps] from comment #6)
> botond: could you please perform a push with `HGRCPATH= hg push` (you may
> need to tack on some --config options to restore some auth settings) so we
> can confirm this is a bug with vanilla Mercurial (and not something
> introduced by an extension)?

I do get the output with `HGRCPATH= `! So, I guess it is a problem related to an extension.

Leaving ni? on me to narrow down which one.

Comment 8

[Botond Ballo [:botond]]

The problematic extension was "evolve". Upgrading to the latest version of "evolve" fixes the problem.

Should I close this, then? Or do we want to understand what specifically went wrong?

Comment 9

[Gregory Szorc [:gps]]

I'm comfortable closing.

"evolve" is a very complex extension and it doesn't surprise me that it somehow managed to break things.