Closed Bug 1505175 Opened 1 year ago Closed 1 year ago

Refactor get_parent_process_actors to only create a DebuggerClient

Categories

(DevTools :: Framework, enhancement, P2)

enhancement

Tracking

(firefox65 fixed)

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

MozReview-Commit-ID: 2ZfghtMuAH2

Depends on D11153
Assignee: nobody → poirot.alex
Comment on attachment 9023206 [details]
Bug 1505175 - Cleanup head_dbg.js from unecessary usages of rootForm.

While I was looking at head_dbg.js, I also did this other cleanup...
MemoryFront now has only two arguments and we no longer need to fetch any rootForm from head_dbg.
Severity: normal → enhancement
Priority: -- → P2
In XPCShell tests, this `console` variable ends up being null and it later triggers an assertion
that makes the test crash in debug builds. We should always pass a defined object to this constructor.

MozReview-Commit-ID: F7QRXD15lH9

Depends on D11154
Comment on attachment 9023888 [details]
Bug 1505175 - Prevent a crash in XPCNativeWrapper call by always passing a non-undefined object.

I had to pile up this additional patch to prevent this test failure/crash:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1b634bb3e93816347e3c1a38a5dd018febdb1a0
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74dbfbf56245
Refactor get_parent_process_actors to only create a DebuggerClient. r=yulia
https://hg.mozilla.org/integration/autoland/rev/47ae67e772a9
Cleanup head_dbg.js from unecessary usages of rootForm. r=yulia
https://hg.mozilla.org/integration/autoland/rev/c26ee8ef2e42
Prevent a crash in XPCNativeWrapper call by always passing a non-undefined object. r=yulia
https://hg.mozilla.org/mozilla-central/rev/74dbfbf56245
https://hg.mozilla.org/mozilla-central/rev/47ae67e772a9
https://hg.mozilla.org/mozilla-central/rev/c26ee8ef2e42
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.