asyncReauthenticateUser doesn't retry upon failure (unlike macOS)

VERIFIED FIXED in Firefox 65

Status

()

enhancement
P1
normal
VERIFIED FIXED
7 months ago
6 months ago

People

(Reporter: MattN, Assigned: franziskus)

Tracking

unspecified
mozilla65
All
Windows
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 verified)

Details

(Whiteboard: [webpayments-reserve])

Attachments

(1 attachment)

If the user enters an incorrect password, they aren't given a chance to try again. I'm not sure if this is an option with the API or whether we can implement our own retry counter.

The main issue is that this behaviour isn't consistent with the macOS version of asyncReauthenticateUser
Assignee: nobody → franziskuskiefer
Status: NEW → ASSIGNED
Priority: P3 → P1
This adds a hard coded number of retries for Windos re-auth. I'm not sure if we want the amount of retries to be fixed or part of the API.
I also changed to always return NS_OK unless a real error occured to make this behave like the macOS version.
Flags: qe-verify+
QA Contact: hani.yacoub

Comment 2

6 months ago
Pushed by franziskuskiefer@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/37dc10164964
allow the user to retry reauthentication on Windows 2 times r=keeler

Comment 3

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/37dc10164964
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65

Comment 4

6 months ago
Verified as fixed on Firefox Nightly 65.0a1 (2018-11-14) on Windows 10 x 64 and Windows 7 x32.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.