1505207 - `mach artifact` telemetry data points have all argv values scrubbed

Status: RESOLVED DUPLICATE of bug 1505325

(Firefox Build System :: General, defect)

Description

[Connor Sheehan [:sheehan]]

Currently all build telemetry data points with `command = 'artifact'` have their argv values stripped to empty strings (ie `["", "", ""]`. Ted did some digging and found the cause of the issue. From IRC:

> sheehan: ahh i figured out why all the arguments to `mach artifact` get filtered out
> https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/telemetry.py#233
> we run it with cwd=~/.mozbuild: https://dxr.mozilla.org/mozilla-central/source/python/mozboot/mozboot/base.py#299
> but then we convert every argument into an absolute path, so filter_args(artifact, ['/build/mozilla-central/mach', 'artifact', 'toolchain', '--from-build', 'linux64-clang'], ['/build/mozilla-central', u'/build/debug-mozilla-central'])
> you get '~/.mozbuild/toolchain', '~/.mozbuild/--from-build', ...]
> and then none of those is relative to the objdir/srcdir, obviously
> maybe we should just stick cwd in the list of paths to use for making relative paths?

I'm not sure if there are other mach commands which will be affected by this issue.

Comment 1

[Connor Sheehan [:sheehan]]

Marking as duplicate of 1505325 since that bug has a more thorough bug report.

Comment 2

[(not currently active) Ted Mielczarek]

Sorry, I missed that you filed this!