1505224 - browser.warnOnQuit needs to be modified to remember tabs

Status: RESOLVED WORKSFORME

(Firefox :: Session Restore, defect)

Description

[Djfe]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

I didn't change my about:config settings but in one of the latest nightly settings the behavior changed how Firefox handles open tabs when it is closed.


Actual results:

I closed the Nightly and got this warning
https://i.imgur.com/KBIIrud.png

I needed to set browser.warnOnQuit to false to make it save my tabs again.
Is this the intended behavior?


Expected results:

Since I set browser.showQuitWarning to true in the past, it should have asked me whether to save tabs and quit (or remember that decision from the past, because I checked the checkbox in that dialog in the past already)

I don't know exactly what the difference between
browser.showQuitWarning
and
browser.warnOnQuit

is

Is the latter one new?

The first one doesn't change anything obvious anymore (when I switch between true and false); I get the same dialog on closing, which asks me whether I want to close the tabs or keep Firefox open.

Comment 1

[Matthias Versen [:Matti]]

browser.showQuitWarning is now longer used since at least Firefox 63 (AFAIK).

Your tabs should be always saved and you should be always able to restore your session manually with menu button->Restore previous session.

What happened in the nightly was a behavior change in bug 550559. 
Since Firefox63 you should not get a quit warning when you close the browser and session restore is configured to open all tabs at startup automatically.
With the change in bug 550559 you get now a warning again if you use the keyboard shortcut to close Firefox.

Comment 2

[:Gijs (he/him)]

Yes, the new dialog is intentional, and the old dialog was removed. If you tick the checkbox in about:preferences to always restore your session, your tabs should be automatically restored when quitting (ie when you accept the dialog that warns you you're closing all the tabs). If you haven't ticked that checkbox, as comment #1 suggested, you can always manually restore tabs, as before.

Comment 3

[Djfe]

I see.
in that case the dialogue is a bit confusing since the text of the remaining dialogue didn't change in comparison to before.
Also (at least in German) it says, that tabs will be closed even if always restore session is activated. Some users could be afraid by this (at first).
Also not everyone knows how to restore tabs/windows by heart

But it works fine for me now. :)

I reset both config entries, checked my settings (it was set to restore sessions already) and then I closed Firefox and removed the checkbox, so I never get asked again.